API, Core: Replace deprecated ContentFile#path usage with location#11550
Merged
amogh-jahagirdar merged 1 commit intoNov 15, 2024
Merged
Conversation
amogh-jahagirdar
force-pushed
the
remove-deprecated-path-usage
branch
2 times, most recently
from
f7641b7 to
5994934
Compare
amogh-jahagirdar
force-pushed
the
remove-deprecated-path-usage
branch
from
5994934 to
523283c
Compare
amogh-jahagirdar
force-pushed
the
remove-deprecated-path-usage
branch
from
523283c to
d71fa4b
Compare
nastra
approved these changes
Nov 15, 2024
Fokko
approved these changes
Nov 15, 2024
jbonofre
approved these changes
Nov 15, 2024
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, thanks @amogh-jahagirdar to remove deprecated code use 😄
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the deprecated ContentFile#path usage with the recommended
locationAPI in the API, Core modules. Will have separate PRs for the other modules, just limited to Core/API for now for reviewer sanity.See #11092 for context on why path was deprecated.