Core: Allow retries for Idempotent Requests with Certain Codes#13449
Merged
Conversation
singhpk234
reviewed
Jul 2, 2025
singhpk234
reviewed
Jul 2, 2025
Member
Author
|
Realizing I need a real E2E test here since I missed the context, will try to get to that tomorrow |
Member
Author
|
Testing code borrowed from #13339 |
singhpk234
approved these changes
Jul 25, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
Looks Great To Me ! Thank you @RussellSpitzer !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was thinking that we should allow for retries for Idempotent Requests from the HTTP Client for 50X issues.