Skip to content

Parquet: Move unchecked suppression down to violating assignment in ParquetMetricsRowGroupFilter #14013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huaxingao merged 1 commit into from
Nov 30, 2025
Merged

Parquet: Move unchecked suppression down to violating assignment in ParquetMetricsRowGroupFilter #14013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {
}

@Override
@SuppressWarnings("unchecked")
public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
int id = ref.fieldId();

Expand All @@ -447,6 +446,7 @@ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
return ROWS_CANNOT_MATCH;
}

@SuppressWarnings("unchecked")
Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
if (colStats != null && !colStats.isEmpty()) {
if (allNulls(colStats, valueCount)) {
Expand Down Expand Up @@ -486,7 +486,6 @@ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
}

@Override
@SuppressWarnings("unchecked")
public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
int id = ref.fieldId();
Long valueCount = valueCounts.get(id);
Expand All @@ -496,6 +495,7 @@ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
return ROWS_MIGHT_MATCH;
}

@SuppressWarnings("unchecked")
Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
if (colStats != null && !colStats.isEmpty()) {
if (mayContainNull(colStats)) {
Expand Down