Skip to content

Core: Use @TempDir in TestTableMetadataParser #14732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 1 commit into from
Dec 2, 2025
Merged

Core: Use @TempDir in TestTableMetadataParser #14732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions core/src/test/java/org/apache/iceberg/TestTableMetadataParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
Expand All @@ -39,9 +38,9 @@
import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.types.Types.BooleanType;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.TestTemplate;
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.api.io.TempDir;

@ExtendWith(ParameterizedTestExtension.class)
public class TestTableMetadataParser {
Expand All @@ -56,10 +55,10 @@ private static List<Object> parameters() {
@Parameter private String codecName;

@TestTemplate
public void testGzipCompressionProperty() throws IOException {
public void testGzipCompressionProperty(@TempDir Path tempDir) throws IOException {
Codec codec = Codec.fromName(codecName);
String fileExtension = getFileExtension(codec);
String fileName = "v3" + fileExtension;
String fileName = tempDir + "/v3" + fileExtension;
OutputFile outputFile = Files.localOutput(fileName);
Map<String, String> properties = Maps.newHashMap();
properties.put(TableProperties.METADATA_COMPRESSION, codecName);
Expand All @@ -71,13 +70,6 @@ public void testGzipCompressionProperty() throws IOException {
verifyMetadata(metadata, actualMetadata);
}

@AfterEach
public void cleanup() throws IOException {
Codec codec = Codec.fromName(codecName);
Path metadataFilePath = Paths.get("v3" + getFileExtension(codec));
java.nio.file.Files.deleteIfExists(metadataFilePath);
}

private void verifyMetadata(TableMetadata expected, TableMetadata actual) {
assertThat(actual.schema().asStruct()).isEqualTo(expected.schema().asStruct());
assertThat(actual.location()).isEqualTo(expected.location());
Expand Down