[MINOR] Switch to FileIO for InputFormat#1526
Merged
Merged
Conversation
Contributor
rdblue
reviewed
Sep 29, 2020
| // For now IcebergInputFormat does its own split planning and does not accept FileSplit instances | ||
| CombinedScanTask task = ((IcebergSplit) split).task(); | ||
| this.context = newContext; | ||
| this.fileIO = new HadoopFileIO(this.context.getConfiguration()); |
Contributor
There was a problem hiding this comment.
Nit: we use this. to distinguish instance fields when setting them, but there's no need when accessing them.
Contributor
Author
There was a problem hiding this comment.
thanks, I'll keep that in mind :)
Contributor
There was a problem hiding this comment.
Good to know! Do we document these style preferences anywhere (using this, when we use the term project vs select, etc)? @rdblue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a TODO saying to switch to FileIO from directly accessing the HadoopInputFile class.