Add names to parameterized tests and simplify the parameters list#1539

Merged

rdblue merged 22 commits into

apache:masterfrom

kbendick:add-names-to-parameterized-tests

Oct 2, 2020

Commits on Oct 1, 2020

Add parameter name notation and simplify for about half of tests
kbendick
committed
Update another to cherry pick over to this branch
kbendick
committed
Update more patameterized tests with names
kbendick
committed
Handle more changes to parameterized names. Will come back to baseNamespace string array problem.
kbendick
committed
Remove attempt to see if the name field of the annotation was a metatemplate that one could code in
kbendick
committed
WIP on a BaseNamespace class that will have a meaningful toString method
kbendick
committed
Add note about plans to handle the String[] baseNamespace
kbendick
committed
Found another case that requires a valid toString method, will handle in another PR
kbendick
committed
Found a class that does not run with all of its parameters - need to find out why
kbendick
committed
Simplify array initializer for Object[][]
kbendick
committed
Fix more template strings and remove commented out code
kbendick
committed
Add in note about adding in true if / when parquet vectorized metadata column support is added
kbendick
committed
Update TODO to be a link to the open issue
kbendick
committed
Add a note about ORC-611 being fixed in newer versions for sub-millisecond min/max stats
kbendick
committed
Update note about failing row group filter metrics test for orc timestamp types
kbendick
committed
Remove unnecessary white space addition
kbendick
committed
Update comment about vectorized parquet reads not supported when filtering by row position from table metadata
kbendick
committed
Further clarify comment about what is not implemented
kbendick
committed
Point to the issue for baseNamespace in the code vs having a TODO
kbendick
committed
Add a note about the issue for baseNamespace in the FlinkCatalog
kbendick
committed
Remove todo about baseNamespace in flink table sink tests as the issue is now referenced in FlinkCatalog directly
kbendick
committed
Mention reference to issue for capturing template paramater type for test output
kbendick
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add names to parameterized tests and simplify the parameters list#1539

Add names to parameterized tests and simplify the parameters list#1539
rdblue merged 22 commits into
apache:masterfrom
kbendick:add-names-to-parameterized-tests

Commits on Oct 1, 2020

Add parameter name notation and simplify for about half of tests

Update another to cherry pick over to this branch

Update more patameterized tests with names

Handle more changes to parameterized names. Will come back to baseNamespace string array problem.

Remove attempt to see if the name field of the annotation was a metatemplate that one could code in

WIP on a BaseNamespace class that will have a meaningful toString method

Add note about plans to handle the String[] baseNamespace

Found another case that requires a valid toString method, will handle in another PR

Found a class that does not run with all of its parameters - need to find out why

Simplify array initializer for Object[][]

Fix more template strings and remove commented out code

Add in note about adding in true if / when parquet vectorized metadata column support is added

Update TODO to be a link to the open issue

Add a note about ORC-611 being fixed in newer versions for sub-millisecond min/max stats

Update note about failing row group filter metrics test for orc timestamp types

Remove unnecessary white space addition

Update comment about vectorized parquet reads not supported when filtering by row position from table metadata

Further clarify comment about what is not implemented

Point to the issue for baseNamespace in the code vs having a TODO

Add a note about the issue for baseNamespace in the FlinkCatalog

Remove todo about baseNamespace in flink table sink tests as the issue is now referenced in FlinkCatalog directly

Mention reference to issue for capturing template paramater type for test output