Core: Relative paths for data files#16666
Open
rambleraptor wants to merge 1 commit into
Open
Conversation
rambleraptor
changed the title
rambleraptor
force-pushed
the
relative-paths-2
branch
from
6d8252b to
9e4a69b
Compare
rambleraptor
force-pushed
the
relative-paths-2
branch
2 times, most recently
from
1e16f03 to
4484754
Compare
rambleraptor
force-pushed
the
relative-paths-2
branch
from
4484754 to
43b5eeb
Compare
Contributor
Author
|
@talatuyarer @danielcweeks as the relative paths gurus, please take a look! @anoopj I know you've been doing work in the space as well |
anoopj
reviewed
Jun 10, 2026
| this.manifestLocation = manifestLocation; | ||
| } | ||
|
|
||
| void setLocation(String location) { |
Member
There was a problem hiding this comment.
This is an open design question, but I think BaseFile is probably not the correct place to inject the location since we want to isolate this to v4-only code paths. Most likely, we will do the path resolution/relativization in the v4-only adapter layer, as done in this prototype.
| file.setFileSequenceNumber(manifestEntry.fileSequenceNumber()); | ||
| file.setManifestLocation(manifestLocation); | ||
| if (baseLocation != null && file.path() != null) { | ||
| file.setLocation(LocationUtil.resolveLocation(baseLocation, file.location())); |
Member
There was a problem hiding this comment.
I'm not certain, but I suspect this might cause manifest rewrite paths to always persist the absolute location. (Appends paths would be fine). I guess the tests are probably passing because the v3 paths are always absolute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading data files using relative paths.
We've had some issues in the prior PR where a bunch of files have scheme-less "absolute" paths. By Iceberg's definition of absolute, those need schemes. I fixed the ones we ran into.