Core: Include row lineage and key-id in snapshot value methods

[manuzhang]

Summary

BaseSnapshot.equals, hashCode, and toString now include the snapshot row-lineage fields firstRowId and addedRows, plus the manifest-list encryption keyId.

This keeps snapshot comparisons and hashes aligned with metadata that changes row ID assignment or encrypted manifest-list key selection. It also makes those values visible in snapshot debug output.

The regression coverage is in TestSnapshot, alongside the snapshot behavior tests.

Testing

• env GRADLE_USER_HOME=/tmp/gradle ./gradlew :iceberg-core:test --tests org.apache.iceberg.TestSnapshot.snapshotValueMethodsIncludeMetadataFields --console=plain
• env GRADLE_USER_HOME=/tmp/gradle ./gradlew :iceberg-core:spotlessJavaCheck --console=plain
• git diff --check

---

AI Disclosure

• Model: GPT-5
• Platform/Tool: Codex
• Human Oversight: partially reviewed
• Prompt Summary: Update Apache Iceberg snapshot value methods to include row-lineage metadata and manifest-list key IDs, with focused snapshot test coverage.

[Copilot]

Pull request overview

This PR updates Iceberg Core’s BaseSnapshot identity semantics so snapshot equality, hashing, and debug output reflect row-lineage state (firstRowId, addedRows). This prevents snapshots that differ only in assigned row ID ranges from comparing equal and makes those values visible when logging/inspecting snapshots.

Changes:

• Extend BaseSnapshot.equals and hashCode to include firstRowId and addedRows.
• Extend BaseSnapshot.toString to include first-row-id and added-rows.
• Add a focused unit test asserting equality/hash behavior and toString visibility for row-lineage fields.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
core/src/main/java/org/apache/iceberg/BaseSnapshot.java	Includes row-lineage fields in equals, hashCode, and toString for correct snapshot identity/debugging.
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java	Adds coverage verifying snapshot equality/hash/toString change with/without row-lineage values.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[singhpk234]

Thanks for the change @manuzhang
I understand this is focusing on RL, though while we are at it, we can also include key-id as well

[RussellSpitzer]

Feels like this was just an oversight before ... I can't think of why we wouldn't include it

[singhpk234]

LGTM too, thanks @manuzhang ! Thanks for review @RussellSpitzer