Fix thread leak in hive-metastore caused by thread pool per HiveTableOperations#6605
Conversation
…created for each HiveTableOperations instance
Contributor
|
Funny thing that I have found the same issue when running the spark tests against my PR: #6570. I have some concerns about the proposed solution:
On the plus side, we do not recreate the pool every time when there is a new HiveTableOperations/Lock |
Author
|
Yes, I have completely missed scenario with multiple hive configurations. |
Contributor
|
For the record #6570 has not been merged yet. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thread leak in hive-metastore caused by new thread pool instance created for each HiveTableOperations instance