Fix NullPointerException when message isn't included with exception#701
Merged
Conversation
Contributor
|
Thanks @cdw9bf! I merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Some thrift exceptions are thrown without a message. When no message is passed, Iceberg will fail with a
NullPointerExceptionwhen trying to check if the string is in the exception message.How does this fix the problem?
Does a
nullcheck in the first clause of theifstatement avoiding checking to see if the string is contained within the message if the message isnull. It should not effect the functionality of the check.Any other important information?
I discovered this error when testing Iceberg for the first time with an improper Hive configuration file. The Thrift exception thrown was because the localhost port it tried to connect to rejected the connection attempt.