Parquet: Revert workaround for resource usage with zstd#7664
Closed
bryanck wants to merge 4 commits into
Closed
Conversation
This reverts commit b8d3ce5.
Contributor
|
Do we have a benchmark to prove the underlying issue has been fixed? |
bryanck
force-pushed
the
revert-parquet-workaround
branch
from
5139deb to
ea24846
Compare
Contributor
Author
|
I'll close this for now, I won't have time to do an analysis any time soon, which I agree should be part of this. |
Contributor
Author
|
I created a new PR for this: #7834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #5681, which is no longer needed with the upgrade to Parquet 1.13. This marks the now-unused codec factory class as deprecated.