Docs: Add/update Snowflake#9669
Conversation
Add Snowflake and make it closer to alphabetical order, keeping open source toward the top, vendors toward the bottom
Include latest docs links
bitsondatadev
left a comment
bitsondatadev
left a comment
There was a problem hiding this comment.
Looks good, but actually brought up a question for me on the ordering of engines in the docs nav. I would suggest just removing the changes and we'll have a discussion around ordering.
| - Doris: https://doris.apache.org/docs/dev/lakehouse/multi-catalog/iceberg | ||
| - Impala: https://impala.apache.org/docs/build/html/topics/impala_iceberg.html | ||
| - Presto: https://prestodb.io/docs/current/connector/iceberg.html | ||
| - Dremio: https://docs.dremio.com/data-formats/apache-iceberg/ | ||
| - Starrocks: https://docs.starrocks.io/en-us/latest/data_source/catalog/iceberg_catalog | ||
| - Trino: https://trino.io/docs/current/connector/iceberg.html | ||
| - Amazon Athena: https://docs.aws.amazon.com/athena/latest/ug/querying-iceberg.html | ||
| - Amazon EMR: https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-use-cluster.html | ||
| - Impala: https://impala.apache.org/docs/build/html/topics/impala_iceberg.html | ||
| - Doris: https://doris.apache.org/docs/dev/lakehouse/multi-catalog/iceberg | ||
| - Clickhouse: https://clickhouse.com/docs/en/engines/table-engines/integrations/iceberg | ||
| - Dremio: https://docs.dremio.com/data-formats/apache-iceberg/ |
There was a problem hiding this comment.
This new ordering confuses me a bit, I believe it's something to discuss as I believe it should just be alphanumeric.
@Fokko @RussellSpitzer @nastra @flyrain @ajantha-bhat, is there any reason we shouldn't just make these alphanumeric?
I believe Spark, Flink, and Trino have the most support and why they came first initially, but as this project grows, it's likely better we just follow alphanumeric everywhere. Unless we want to group engines by some metric of Iceberg support and then alphanumeric.
Let me know what you all think and if this should be a topic at the next sync.
There was a problem hiding this comment.
Alphanumeric order makes sense to me. But it may mess up with other non-engine pages like Table, API. Should we introduce another top-level index to group all engines(Spark, Flink, Snowflake, PyIceberg, etc)?
bitsondatadev
left a comment
bitsondatadev
left a comment
There was a problem hiding this comment.
Thanks @scottteal LGTM!
* Update sidebar Add Snowflake and make it closer to alphabetical order, keeping open source toward the top, vendors toward the bottom * Update Snowflake's description Include latest docs links * Add Snowflake without disrupting ordering
* Update sidebar Add Snowflake and make it closer to alphabetical order, keeping open source toward the top, vendors toward the bottom * Update Snowflake's description Include latest docs links * Add Snowflake without disrupting ordering
4 participants
My last pull request wasn't merged before docs were switched, so submitting this one editing the correct files post-switch
Old PR: #9557
FYI @bitsondatadev