Add issue template and docs for iceberg proposals#9932
Merged
Conversation
Contributor
Author
|
@jbonofre I'm not sure why I can't add you as a reviewer. |
Member
What I observed is only collaborators, committers can be added as reviewer. So, I manually CC them in the PR for review if required. |
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks for this, just added some minor nits.
Member
|
@danielcweeks That's because my user is not in the |
nastra
reviewed
Mar 13, 2024
nastra
reviewed
Mar 13, 2024
nastra
reviewed
Mar 13, 2024
nastra
approved these changes
Mar 13, 2024
Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
liurenjie1024
approved these changes
Mar 14, 2024
jbonofre
reviewed
Mar 14, 2024
jbonofre
reviewed
Mar 14, 2024
jbonofre
approved these changes
Mar 14, 2024
stevenzwu
approved these changes
Mar 20, 2024
rdblue
approved these changes
Mar 20, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
* Add issue template and docs for iceberg proposals * Add vote clarification * Update site/docs/contribute.md Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> * Update site/docs/contribute.md Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> * Update .github/ISSUE_TEMPLATE/iceberg_proposal.yml Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com> * Fix issue template link * Address comments --------- Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an issue template for Iceberg improvement proposals and adds docs to the site to cover the proposal process.