Migrate Manifest, FormatVersion and LocationProvider files in Core to JUnit5#9964
Merged
Conversation
tomtongue
changed the title
Contributor
Author
|
@nastra Migrate additional classes to JUnit5. Could you review when you have time? |
nastra
reviewed
Mar 18, 2024
| assertThat(partitionFieldSummary.containsNull()).isFalse(); | ||
| assertThat(partitionFieldSummary.containsNaN()).isFalse(); | ||
| assertThat( | ||
| (Integer) |
Contributor
There was a problem hiding this comment.
is the casting necessary here?
nastra
approved these changes
Mar 18, 2024
Contributor
Author
|
@nastra Thanks for the quick review! |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the following test classes in iceberg-core to JUnit 5 and AssertJ style for #9085.
Current Progress
TestManifestCaching.javaTestManifestCleanup.javaTestManifestEncryption.javaTestManifestListVersions.javaTestManifestReader.java(already uses JUnit5)TestManifestReaderStats.javaTestManifestWriter.javaTestManifestWriterVersions.javaAdditional classes:
TestFormatVersions.javaTestLocationProvider.java