Skip to content

Hive: Tests to do validation hive content and iceberg table with the same name #9980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 2 commits into from
Mar 26, 2024
Merged

Hive: Tests to do validation hive content and iceberg table with the same name #9980

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a73f37
Hive: Test to do validation hive content and iceberg table with the s…
nk1506 Mar 17, 2024
7e310d1
Addressed comments: Used parameters for testHiveTableAndIcebergTable…
nk1506 Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 43 additions & 4 deletions hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.exceptions.AlreadyExistsException;
import org.apache.iceberg.exceptions.CommitFailedException;
import org.apache.iceberg.exceptions.NoSuchIcebergTableException;
import org.apache.iceberg.exceptions.NoSuchTableException;
import org.apache.iceberg.exceptions.NotFoundException;
import org.apache.iceberg.hadoop.ConfigProperties;
Expand All @@ -79,6 +80,8 @@
import org.apache.thrift.TException;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.EnumSource;

public class HiveTableTest extends HiveTableBaseTest {
static final String NON_DEFAULT_DATABASE = "nondefault";
Expand Down Expand Up @@ -334,7 +337,8 @@ public void testListTables() throws TException, IOException {

// create a hive table
String hiveTableName = "test_hive_table";
org.apache.hadoop.hive.metastore.api.Table hiveTable = createHiveTable(hiveTableName);
org.apache.hadoop.hive.metastore.api.Table hiveTable =
createHiveTable(hiveTableName, TableType.EXTERNAL_TABLE);
HIVE_METASTORE_EXTENSION.metastoreClient().createTable(hiveTable);

catalog.setListAllTables(false);
Expand All @@ -349,8 +353,43 @@ public void testListTables() throws TException, IOException {
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME, hiveTableName);
}

private org.apache.hadoop.hive.metastore.api.Table createHiveTable(String hiveTableName)
throws IOException {
@ParameterizedTest
@EnumSource(
value = TableType.class,
names = {"EXTERNAL_TABLE", "VIRTUAL_VIEW", "MANAGED_TABLE"})
public void testHiveTableAndIcebergTableWithSameName(TableType tableType)
throws TException, IOException {

assertThat(catalog.listTables(TABLE_IDENTIFIER.namespace()))
.hasSize(1)
.containsExactly(TABLE_IDENTIFIER);

// create a hive table with a defined table type.
String hiveTableName = "test_hive_table";
TableIdentifier identifier = TableIdentifier.of(DB_NAME, hiveTableName);
HIVE_METASTORE_EXTENSION
.metastoreClient()
.createTable(createHiveTable(hiveTableName, tableType));

catalog.setListAllTables(true);
assertThat(catalog.listTables(TABLE_IDENTIFIER.namespace()))
.hasSize(2)
.containsExactly(TABLE_IDENTIFIER, identifier);
catalog.setListAllTables(false); // reset to default.

// create an iceberg table with the same name
assertThatThrownBy(() -> catalog.createTable(identifier, schema, PartitionSpec.unpartitioned()))
.isInstanceOf(NoSuchIcebergTableException.class)
.hasMessageStartingWith(String.format("Not an iceberg table: hive.%s", identifier));
Comment thread
nastra marked this conversation as resolved.

assertThat(catalog.tableExists(identifier)).isFalse();

assertThat(catalog.tableExists(TABLE_IDENTIFIER)).isTrue();
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME, hiveTableName);
}

private org.apache.hadoop.hive.metastore.api.Table createHiveTable(
String hiveTableName, TableType type) throws IOException {
Map<String, String> parameters = Maps.newHashMap();
parameters.put(
serdeConstants.SERIALIZATION_CLASS, "org.apache.hadoop.hive.serde2.thrift.test.IntString");
Expand Down Expand Up @@ -387,7 +426,7 @@ private org.apache.hadoop.hive.metastore.api.Table createHiveTable(String hiveTa
Maps.newHashMap(),
"viewOriginalText",
"viewExpandedText",
TableType.EXTERNAL_TABLE.name());
type.name());
return hiveTable;
}

Expand Down