refactor(csharp): rename asynchronous methods to have Async suffix (#2994)

lukaszzborek · web-flow · commit 38bf2dc4cc7c · 2026-03-21T12:12:21.000+01:00
diff --git a/examples/csharp/src/Basic/Iggy_SDK.Examples.Basic.Consumer/Program.cs b/examples/csharp/src/Basic/Iggy_SDK.Examples.Basic.Consumer/Program.cs
@@ -45,7 +45,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser(settings.Username, settings.Password);
+await client.LoginUserAsync(settings.Username, settings.Password);
 
 logger.LogInformation("Basic consumer has logged on successfully");
 
diff --git a/examples/csharp/src/Basic/Iggy_SDK.Examples.Basic.Producer/Program.cs b/examples/csharp/src/Basic/Iggy_SDK.Examples.Basic.Producer/Program.cs
@@ -46,7 +46,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser(settings.Username, settings.Password);
+await client.LoginUserAsync(settings.Username, settings.Password);
 
 logger.LogInformation("Basic producer has logged on successfully");
 
diff --git a/examples/csharp/src/GettingStarted/Iggy_SDK.Examples.GettingStarted.Consumer/Program.cs b/examples/csharp/src/GettingStarted/Iggy_SDK.Examples.GettingStarted.Consumer/Program.cs
@@ -32,6 +32,6 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 await Utils.ConsumeMessages(client, logger);
diff --git a/examples/csharp/src/GettingStarted/Iggy_SDK.Examples.GettingStarted.Producer/Program.cs b/examples/csharp/src/GettingStarted/Iggy_SDK.Examples.GettingStarted.Producer/Program.cs
@@ -32,7 +32,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 await Utils.InitSystem(client, logger);
 await Utils.ProduceMessages(client, logger);
diff --git a/examples/csharp/src/MessageEnvelope/Iggy_SDK.Examples.MessageEnvelope.Consumer/Program.cs b/examples/csharp/src/MessageEnvelope/Iggy_SDK.Examples.MessageEnvelope.Consumer/Program.cs
@@ -32,6 +32,6 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 await Utils.ConsumeMessages(client, logger);
diff --git a/examples/csharp/src/MessageEnvelope/Iggy_SDK.Examples.MessageEnvelope.Producer/Program.cs b/examples/csharp/src/MessageEnvelope/Iggy_SDK.Examples.MessageEnvelope.Producer/Program.cs
@@ -32,7 +32,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 await Utils.InitSystem(client, logger);
 await Utils.ProduceMessages(client, logger);
diff --git a/examples/csharp/src/MessageHeaders/Iggy_SDK.Examples.MessageHeaders.Consumer/Program.cs b/examples/csharp/src/MessageHeaders/Iggy_SDK.Examples.MessageHeaders.Consumer/Program.cs
@@ -32,6 +32,6 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 await Utils.ConsumeMessages(client, logger);
diff --git a/examples/csharp/src/MessageHeaders/Iggy_SDK.Examples.MessageHeaders.Producer/Program.cs b/examples/csharp/src/MessageHeaders/Iggy_SDK.Examples.MessageHeaders.Producer/Program.cs
@@ -32,7 +32,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 await Utils.InitSystem(client, logger);
 await Utils.ProduceMessages(client, logger);
diff --git a/examples/csharp/src/NewSdk/Iggy_SDK.Examples.NewSdk.Consumer/Program.cs b/examples/csharp/src/NewSdk/Iggy_SDK.Examples.NewSdk.Consumer/Program.cs
@@ -36,7 +36,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 var consumer = client.CreateConsumerBuilder(Identifier.String("new-sdk-stream"), Identifier.String("new-sdk-topic"),
         Consumer.Group("new-sdk-consumer-group"))
diff --git a/examples/csharp/src/NewSdk/Iggy_SDK.Examples.NewSdk.Producer/Program.cs b/examples/csharp/src/NewSdk/Iggy_SDK.Examples.NewSdk.Producer/Program.cs
@@ -34,7 +34,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 
 var publisher = client.CreatePublisherBuilder(Identifier.String("new-sdk-stream"), Identifier.String("new-sdk-topic"))
     .CreateStreamIfNotExists("new-sdk-stream")
@@ -45,4 +45,4 @@
 
 await publisher.InitAsync();
 await Utils.ProduceMessages(publisher, logger);
-await publisher.WaitUntilAllSends();
+await publisher.WaitUntilAllSendsAsync();
diff --git a/examples/csharp/src/NewSdk/Iggy_SDK.Examples.NewSdk.Producer/Utils.cs b/examples/csharp/src/NewSdk/Iggy_SDK.Examples.NewSdk.Producer/Utils.cs
@@ -71,7 +71,7 @@ public static async Task ProduceMessages(IggyPublisher publisher, ILogger logger
 
             logger.LogInformation("Sending messages count: {Count}", messagesPerBatch);
 
-            await publisher.SendMessages(messages.ToArray());
+            await publisher.SendMessagesAsync(messages.ToArray());
 
             sentBatches++;
             logger.LogInformation("Sent messages: {Messages}", serializableMessages);
diff --git a/examples/csharp/src/TcpTls/Iggy_SDK.Examples.TcpTls.Consumer/Program.cs b/examples/csharp/src/TcpTls/Iggy_SDK.Examples.TcpTls.Consumer/Program.cs
@@ -60,7 +60,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 logger.LogInformation("Connected and logged in over TLS.");
 
 await ConsumeMessages();
diff --git a/examples/csharp/src/TcpTls/Iggy_SDK.Examples.TcpTls.Producer/Program.cs b/examples/csharp/src/TcpTls/Iggy_SDK.Examples.TcpTls.Producer/Program.cs
@@ -61,7 +61,7 @@
 });
 
 await client.ConnectAsync();
-await client.LoginUser("iggy", "iggy");
+await client.LoginUserAsync("iggy", "iggy");
 logger.LogInformation("Connected and logged in over TLS.");
 
 await InitSystem();
diff --git a/foreign/csharp/Benchmarks/Program.cs b/foreign/csharp/Benchmarks/Program.cs
@@ -56,7 +56,7 @@
 #endif
     });
 
-    await bus.LoginUser("iggy", "iggy");
+    await bus.LoginUserAsync("iggy", "iggy");
     clients[i] = bus;
 }
 
diff --git a/foreign/csharp/Iggy_SDK.Tests.BDD/StepDefinitions/BasicMessagingOperationsSteps.cs b/foreign/csharp/Iggy_SDK.Tests.BDD/StepDefinitions/BasicMessagingOperationsSteps.cs
@@ -55,7 +55,7 @@ public async Task GivenIHaveARunningIggyServer()
     [Given(@"I am authenticated as the root user")]
     public async Task GivenIAmAuthenticatedAsTheRootUser()
     {
-        var loginResult = await _context.IggyClient.LoginUser("iggy", "iggy");
+        var loginResult = await _context.IggyClient.LoginUserAsync("iggy", "iggy");
 
         loginResult.ShouldNotBeNull();
         loginResult.UserId.ShouldBe(0);
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/ClusterRedirectionTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/ClusterRedirectionTests.cs
@@ -40,7 +40,7 @@ public async Task ConnectToFollower_Should_ReturnClusterMetadataWithTwoNodes()
             AutoLoginSettings = new AutoLoginSettings { Enabled = false }
         });
         await client.ConnectAsync();
-        await client.LoginUser("iggy", "iggy");
+        await client.LoginUserAsync("iggy", "iggy");
 
         var metadata = await client.GetClusterMetadataAsync();
 
@@ -84,7 +84,7 @@ public async Task ConnectToFollowerWithManualLogin_Should_RedirectToLeader()
             AutoLoginSettings = new AutoLoginSettings { Enabled = false }
         });
         await client.ConnectAsync();
-        await client.LoginUser("iggy", "iggy");
+        await client.LoginUserAsync("iggy", "iggy");
 
         var address = client.GetCurrentAddress();
         address.ShouldNotBeNullOrEmpty();
@@ -103,7 +103,7 @@ public async Task ConnectToFollowerWithPersonalAccessToken_Should_RedirectToLead
             AutoLoginSettings = new AutoLoginSettings { Enabled = false }
         });
         await leaderClient.ConnectAsync();
-        await leaderClient.LoginUser("iggy", "iggy");
+        await leaderClient.LoginUserAsync("iggy", "iggy");
 
         var name = $"pat-{Guid.NewGuid():N}"[..20];
         var pat = await leaderClient.CreatePersonalAccessTokenAsync(name, TimeSpan.FromHours(1));
@@ -117,7 +117,7 @@ public async Task ConnectToFollowerWithPersonalAccessToken_Should_RedirectToLead
             AutoLoginSettings = new AutoLoginSettings { Enabled = false }
         });
         await client.ConnectAsync();
-        var authResponse = await client.LoginWithPersonalAccessToken(pat.Token);
+        var authResponse = await client.LoginWithPersonalAccessTokenAsync(pat.Token);
 
         authResponse.ShouldNotBeNull();
         authResponse.UserId.ShouldBeGreaterThanOrEqualTo(0);
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/ConsumerGroupTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/ConsumerGroupTests.cs
@@ -196,7 +196,7 @@ public async Task GetConsumerGroupById_WithMembers_Should_Return_ValidResponse(P
         {
             var memberClient = await Fixture.CreateClient(Protocol.Tcp);
             clients.Add(memberClient);
-            await memberClient.LoginUser("iggy", "iggy");
+            await memberClient.LoginUserAsync("iggy", "iggy");
             await memberClient.JoinConsumerGroupAsync(Identifier.String(streamName),
                 Identifier.String(TopicName), Identifier.Numeric(cg!.Id));
         }
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/Fixtures/IggyServerFixture.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/Fixtures/IggyServerFixture.cs
@@ -174,7 +174,7 @@ public async Task<IIggyClient> CreateTcpClient(string userName = "iggy", string
 
         if (connect)
         {
-            await client.LoginUser(userName, password);
+            await client.LoginUserAsync(userName, password);
         }
 
         return client;
@@ -184,7 +184,7 @@ public async Task<IIggyClient> CreateHttpClient(string userName = "iggy", string
     {
         var client = await CreateClient(Protocol.Http);
 
-        await client.LoginUser(userName, password);
+        await client.LoginUserAsync(userName, password);
 
         return client;
     }
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/IggyPublisherTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/IggyPublisherTests.cs
@@ -128,7 +128,7 @@ public async Task SendMessages_WithoutInit_Should_Throw_PublisherNotInitializedE
             new(Guid.NewGuid(), Encoding.UTF8.GetBytes("Test message"))
         };
 
-        await Should.ThrowAsync<PublisherNotInitializedException>(() => publisher.SendMessages(messages));
+        await Should.ThrowAsync<PublisherNotInitializedException>(() => publisher.SendMessagesAsync(messages));
         await publisher.DisposeAsync();
     }
 
@@ -155,7 +155,7 @@ public async Task SendMessages_Should_SendMessages_Successfully(Protocol protoco
             messages.Add(new Message(Guid.NewGuid(), Encoding.UTF8.GetBytes($"Test message {i}")));
         }
 
-        await Should.NotThrowAsync(() => publisher.SendMessages(messages));
+        await Should.NotThrowAsync(() => publisher.SendMessagesAsync(messages));
 
         // Verify messages were sent by polling them
         var polledMessages = await client.PollMessagesAsync(
@@ -189,7 +189,7 @@ public async Task SendMessages_WithEmptyList_Should_NotThrow(Protocol protocol)
         await publisher.InitAsync();
 
         var emptyMessages = new List<Message>();
-        await Should.NotThrowAsync(() => publisher.SendMessages(emptyMessages));
+        await Should.NotThrowAsync(() => publisher.SendMessagesAsync(emptyMessages));
         await publisher.DisposeAsync();
     }
 
@@ -320,8 +320,8 @@ public async Task SendMessages_WithBackgroundSending_Should_SendMessages_Success
             messages.Add(new Message(Guid.NewGuid(), Encoding.UTF8.GetBytes($"Background message {i}")));
         }
 
-        await publisher.SendMessages(messages);
-        await publisher.WaitUntilAllSends();
+        await publisher.SendMessagesAsync(messages);
+        await publisher.WaitUntilAllSendsAsync();
 
         // Verify messages were sent
         var polledMessages = await client.PollMessagesAsync(
@@ -361,11 +361,11 @@ public async Task WaitUntilAllSends_Should_WaitForPendingMessages(Protocol proto
             messages.Add(new Message(Guid.NewGuid(), Encoding.UTF8.GetBytes($"Wait test message {i}")));
         }
 
-        await publisher.SendMessages(messages);
+        await publisher.SendMessagesAsync(messages);
 
         // Should not return immediately
         var startTime = DateTime.UtcNow;
-        await publisher.WaitUntilAllSends();
+        await publisher.WaitUntilAllSendsAsync();
         var elapsed = DateTime.UtcNow - startTime;
 
         // Should have taken some time to flush
@@ -393,7 +393,7 @@ public async Task WaitUntilAllSends_WithoutBackgroundSending_Should_ReturnImmedi
         await publisher.InitAsync();
 
         // Should return immediately without background sending
-        await Should.NotThrowAsync(() => publisher.WaitUntilAllSends());
+        await Should.NotThrowAsync(() => publisher.WaitUntilAllSendsAsync());
         await publisher.DisposeAsync();
     }
 
@@ -424,7 +424,7 @@ public async Task SendMessages_ToMultiplePartitions_Should_DistributeMessages(Pr
                     Encoding.UTF8.GetBytes($"Partition {partitionId} message {i}")));
             }
 
-            await publisher.SendMessages(messages);
+            await publisher.SendMessagesAsync(messages);
             await publisher.DisposeAsync();
         }
 
@@ -468,7 +468,7 @@ public async Task SendMessages_WithBalancedPartitioning_Should_DistributeAcrossP
             messages.Add(new Message(Guid.NewGuid(), Encoding.UTF8.GetBytes($"Balanced message {i}")));
         }
 
-        await publisher.SendMessages(messages);
+        await publisher.SendMessagesAsync(messages);
 
         // Verify messages are distributed across partitions
         var totalMessages = 0;
@@ -610,8 +610,8 @@ public async Task SendMessages_LargeMessageCount_Should_HandleCorrectly(Protocol
             messages.Add(new Message(Guid.NewGuid(), Encoding.UTF8.GetBytes($"Large batch message {i}")));
         }
 
-        await publisher.SendMessages(messages);
-        await publisher.WaitUntilAllSends();
+        await publisher.SendMessagesAsync(messages);
+        await publisher.WaitUntilAllSendsAsync();
 
         // Verify at least most messages were sent
         var polledMessages = await client.PollMessagesAsync(
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/IggyTlsConnectionTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/IggyTlsConnectionTests.cs
@@ -52,7 +52,7 @@ public async Task Connect_WithTls_Should_Connect_Successfully()
         });
 
         await client.ConnectAsync();
-        var loginResult = await client.LoginUser("iggy", "iggy");
+        var loginResult = await client.LoginUserAsync("iggy", "iggy");
 
         loginResult.ShouldNotBeNull();
     }
@@ -68,7 +68,7 @@ public async Task Connect_WithoutTls_Should_Throw_WhenTlsIsRequired()
         });
 
         await client.ConnectAsync();
-        await Should.ThrowAsync<IggyZeroBytesException>(client.LoginUser("iggy", "iggy"));
+        await Should.ThrowAsync<IggyZeroBytesException>(client.LoginUserAsync("iggy", "iggy"));
     }
 
     [Test]
@@ -94,7 +94,7 @@ public async Task Connect_WithTls_CA_Should_Connect_Successfully()
         });
 
         await client.ConnectAsync();
-        var loginResult = await client.LoginUser("iggy", "iggy");
+        var loginResult = await client.LoginUserAsync("iggy", "iggy");
 
         loginResult.ShouldNotBeNull();
     }
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/PersonalAccessTokenTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/PersonalAccessTokenTests.cs
@@ -88,7 +88,7 @@ public async Task LoginWithPersonalAccessToken_Should_Be_Successfully(Protocol p
         var response = await client.CreatePersonalAccessTokenAsync(name, Expiry);
 
         var loginClient = await Fixture.CreateClient(protocol);
-        var authResponse = await loginClient.LoginWithPersonalAccessToken(response!.Token);
+        var authResponse = await loginClient.LoginWithPersonalAccessTokenAsync(response!.Token);
 
         authResponse.ShouldNotBeNull();
         authResponse.UserId.ShouldBeGreaterThanOrEqualTo(0);
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/SystemTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/SystemTests.cs
@@ -57,7 +57,7 @@ public async Task GetClient_Should_Return_CorrectClient(Protocol protocol)
         var client = await Fixture.CreateAuthenticatedClient(protocol);
 
         var tcpClient = await Fixture.CreateClient(Protocol.Tcp);
-        await tcpClient.LoginUser("iggy", "iggy");
+        await tcpClient.LoginUserAsync("iggy", "iggy");
         var clientInfo = await tcpClient.GetMeAsync();
         clientInfo.ShouldNotBeNull();
 
@@ -105,7 +105,7 @@ public async Task GetClient_WithConsumerGroup_Should_Return_CorrectClient(Protoc
 
         var streamName = $"sys-cg-{Guid.NewGuid():N}";
         var tcpClient = await Fixture.CreateClient(Protocol.Tcp);
-        await tcpClient.LoginUser("iggy", "iggy");
+        await tcpClient.LoginUserAsync("iggy", "iggy");
 
         var stream = await tcpClient.CreateStreamAsync(streamName);
         await tcpClient.CreateTopicAsync(Identifier.String(streamName), "first_topic", 2);
diff --git a/foreign/csharp/Iggy_SDK.Tests.Integration/UsersTests.cs b/foreign/csharp/Iggy_SDK.Tests.Integration/UsersTests.cs
diff --git a/foreign/csharp/Iggy_SDK/Consumers/IggyConsumer.cs b/foreign/csharp/Iggy_SDK/Consumers/IggyConsumer.cs
diff --git a/foreign/csharp/Iggy_SDK/Contracts/Auth/GlobalPermissions.cs b/foreign/csharp/Iggy_SDK/Contracts/Auth/GlobalPermissions.cs
diff --git a/foreign/csharp/Iggy_SDK/IggyClient/IIggyPersonalAccessToken.cs b/foreign/csharp/Iggy_SDK/IggyClient/IIggyPersonalAccessToken.cs
diff --git a/foreign/csharp/Iggy_SDK/IggyClient/IIggyUsers.cs b/foreign/csharp/Iggy_SDK/IggyClient/IIggyUsers.cs
diff --git a/foreign/csharp/Iggy_SDK/IggyClient/Implementations/HttpMessageStream.cs b/foreign/csharp/Iggy_SDK/IggyClient/Implementations/HttpMessageStream.cs
diff --git a/foreign/csharp/Iggy_SDK/IggyClient/Implementations/TcpMessageStream.cs b/foreign/csharp/Iggy_SDK/IggyClient/Implementations/TcpMessageStream.cs
diff --git a/foreign/csharp/Iggy_SDK/Iggy_SDK.csproj b/foreign/csharp/Iggy_SDK/Iggy_SDK.csproj
diff --git a/foreign/csharp/Iggy_SDK/Publishers/IggyPublisher.cs b/foreign/csharp/Iggy_SDK/Publishers/IggyPublisher.cs
diff --git a/foreign/csharp/Iggy_SDK/Publishers/IggyPublisherOfT.cs b/foreign/csharp/Iggy_SDK/Publishers/IggyPublisherOfT.cs
diff --git a/foreign/csharp/README.md b/foreign/csharp/README.md
