Skip to content

refactor(csharp): rename asynchronous methods to have Async suffix #2994

Merged
hubcio merged 4 commits intoapache:masterfrom
lukaszzborek:refactor/dotnet-method-naming
Mar 21, 2026
Merged

refactor(csharp): rename asynchronous methods to have Async suffix #2994
hubcio merged 4 commits intoapache:masterfrom
lukaszzborek:refactor/dotnet-method-naming

Conversation

@lukaszzborek
Copy link
Copy Markdown
Contributor

@lukaszzborek lukaszzborek commented Mar 20, 2026

  • rename async methods to have Async suffix (a few methods didn't have it)

BREAKING

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.87%. Comparing base (50557dc) to head (ce2fb3b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ign/csharp/Iggy_SDK/Publishers/IggyPublisherOfT.cs 0.00% 3 Missing ⚠️
...SDK/IggyClient/Implementations/TcpMessageStream.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2994      +/-   ##
============================================
- Coverage     71.88%   71.87%   -0.02%     
  Complexity      930      930              
============================================
  Files          1117     1117              
  Lines         92952    92952              
  Branches      70474    70485      +11     
============================================
- Hits          66815    66805      -10     
+ Misses        23577    23576       -1     
- Partials       2560     2571      +11     
Flag Coverage Δ
csharp 67.45% <71.42%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
foreign/csharp/Iggy_SDK/Consumers/IggyConsumer.cs 62.00% <100.00%> (ø)
...sharp/Iggy_SDK/Contracts/Auth/GlobalPermissions.cs 100.00% <ø> (ø)
...DK/IggyClient/Implementations/HttpMessageStream.cs 71.72% <ø> (ø)
...oreign/csharp/Iggy_SDK/Publishers/IggyPublisher.cs 78.98% <100.00%> (ø)
...SDK/IggyClient/Implementations/TcpMessageStream.cs 76.33% <66.66%> (ø)
...ign/csharp/Iggy_SDK/Publishers/IggyPublisherOfT.cs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio merged commit 38bf2dc into apache:master Mar 21, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants