feat(cpp): Add functions related to consumer groups#2988
Open
slbotbm wants to merge 7 commits intoapache:masterfrom
Open
feat(cpp): Add functions related to consumer groups#2988slbotbm wants to merge 7 commits intoapache:masterfrom
slbotbm wants to merge 7 commits intoapache:masterfrom
Conversation
7c8fb2e to
4b9521d
Compare
4e2911b to
fd621b9
Compare
Contributor
Author
|
This PR is ready for review. |
amlel-el-mahrouss
left a comment
There was a problem hiding this comment.
Here's my first review @slbotbm, let me know your reply by pinging me
Contributor
Author
|
Converting this to a draft since I would like to think a little more deeply about the API we will be exposing. |
…eate identifiers in rust.
Contributor
Author
|
This PR is ready for review. I was unsure of how to expose the consumer interface to the user, and decided that an additional opaque consumer type will be necessary (to be done in a future PR). The client can now only create or delete consumer groups, but cannot join or read from them. The consumers will be able to join and leave the groups, and also read messages. The lifetimes and safety guarantees of this additional type will still need to be thought through, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Works towards completion of #2763
Rationale
Additions to the cpp bindings to make it feature complete.
What changed?
Add consumer-group creating and deletion functions. Also adds commented out purge_topic and purge_stream but those require the ability to actually send messages to the server, which is not yet implemented. Will be added once they can be tested. Also adds create_partition, delete_partitions, and functions that allow cpp user to directly create identifiers instead of manually defining everything.
Local Execution
AI Usage
If AI tools were used, please answer: