Skip to content

feat(cpp): Add functions related to consumer groups#2988

Open
slbotbm wants to merge 7 commits intoapache:masterfrom
slbotbm:cpp-low-level-client
Open

feat(cpp): Add functions related to consumer groups#2988
slbotbm wants to merge 7 commits intoapache:masterfrom
slbotbm:cpp-low-level-client

Conversation

@slbotbm
Copy link
Copy Markdown
Contributor

@slbotbm slbotbm commented Mar 20, 2026

Which issue does this PR close?

Works towards completion of #2763

Rationale

Additions to the cpp bindings to make it feature complete.

What changed?

Add consumer-group creating and deletion functions. Also adds commented out purge_topic and purge_stream but those require the ability to actually send messages to the server, which is not yet implemented. Will be added once they can be tested. Also adds create_partition, delete_partitions, and functions that allow cpp user to directly create identifiers instead of manually defining everything.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

If AI tools were used, please answer:

  1. codex
  2. code generation
  3. manual planning and inspection, local execution
  4. Can you explain every line of the code if asked? Yes

@slbotbm slbotbm marked this pull request as draft March 20, 2026 14:01
@slbotbm slbotbm changed the title feat(cpp): Add functions related to consumer groups (WIP) feat(cpp): Add functions related to consumer groups Mar 20, 2026
@slbotbm slbotbm marked this pull request as ready for review March 20, 2026 15:17
@slbotbm slbotbm force-pushed the cpp-low-level-client branch from 7c8fb2e to 4b9521d Compare March 20, 2026 15:19
@slbotbm slbotbm marked this pull request as draft March 20, 2026 15:36
@slbotbm slbotbm force-pushed the cpp-low-level-client branch from 4e2911b to fd621b9 Compare March 21, 2026 12:16
@slbotbm slbotbm marked this pull request as ready for review March 21, 2026 12:23
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Mar 21, 2026

This PR is ready for review.

Copy link
Copy Markdown

@amlel-el-mahrouss amlel-el-mahrouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my first review @slbotbm, let me know your reply by pinging me

@slbotbm slbotbm marked this pull request as draft March 24, 2026 17:12
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Mar 24, 2026

Converting this to a draft since I would like to think a little more deeply about the API we will be exposing.

@slbotbm slbotbm marked this pull request as ready for review March 27, 2026 09:13
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Mar 27, 2026

This PR is ready for review. I was unsure of how to expose the consumer interface to the user, and decided that an additional opaque consumer type will be necessary (to be done in a future PR). The client can now only create or delete consumer groups, but cannot join or read from them. The consumers will be able to join and leave the groups, and also read messages. The lifetimes and safety guarantees of this additional type will still need to be thought through, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants