fix(security): replace SecretString with String for API response tokens#3008
Merged
fix(security): replace SecretString with String for API response tokens#3008
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3008 +/- ##
============================================
- Coverage 72.18% 72.13% -0.06%
Complexity 930 930
============================================
Files 1122 1120 -2
Lines 93502 93489 -13
Branches 70851 70849 -2
============================================
- Hits 67494 67437 -57
- Misses 23441 23461 +20
- Partials 2567 2591 +24
🚀 New features to boost your workflow:
|
mmodzelewski
previously approved these changes
Mar 23, 2026
ryankert01
approved these changes
Mar 23, 2026
krishvishal
approved these changes
Mar 23, 2026
mmodzelewski
approved these changes
Mar 25, 2026
atharvalade
approved these changes
Mar 25, 2026
hubcio
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK consumers had to depend on the secrecy crate just to read
token values returned from create-PAT and login endpoints.
These are API response fields intentionally exposed to the
caller over the wire — wrapping them in SecretString added
friction (custom Debug impls, serialize_secret annotations,
expose_secret() calls) without meaningful security benefit.
Changes RawPersonalAccessToken.token and TokenInfo.token from
SecretString to plain String. Leaves SecretString in place for
actual secrets: user passwords, credentials, and PAT values
used in login commands.