Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3019 +/- ##
============================================
- Coverage 71.76% 71.74% -0.02%
Complexity 943 943
============================================
Files 1121 1121
Lines 93800 93800
Branches 71125 71135 +10
============================================
- Hits 67315 67298 -17
- Misses 23851 23852 +1
- Partials 2634 2650 +16
🚀 New features to boost your workflow:
|
|
I dug through the hardcoded bits in this PR. The main problem is not the number of scenarios, it is that There are two buckets here:
Those are properties of the CI environment and smoke path, so keeping them in the workflow is fine.
That second bucket is where the PR feels too hardcoded, because it creates a second source of truth in CI. If you want to keep this structure, I would suggest a cleaner split:
That keeps the Helm chart as the owner of chart data and makes version/tag bumps less noisy. |
There was a problem hiding this comment.
overall looks nice, but please don't put bash scripts in _test.yml - please move the actual scenario (not setup) to scripts/ci/test_helm.sh and call it from action context. we want to allow the devs to run this locally. it has to work this way too.
|
@avirajkhare00 looks like your newly added smoke test failed |
|
@hubcio race condition it was: https://stackoverflow.com/questions/68576225/failed-calling-webhook-validate-nginx-ingress-kubernetes-io-error-while-apply thankfullly its fixed |
Summary
helmcomponent to change detection sohelm/**routes through the existingother_matrixhelm lint --strict, and the 6 requested render scenarios in_test.ymlnetworking.k8s.io/v1beta1andautoscaling/v2beta2Closes #3007