feat(consensus): add ClientsTable for duplicate detection and reply caching#3023
Open
krishvishal wants to merge 2 commits intoapache:masterfrom
Open
feat(consensus): add ClientsTable for duplicate detection and reply caching#3023krishvishal wants to merge 2 commits intoapache:masterfrom
krishvishal wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3023 +/- ##
==========================================
Coverage 71.74% 71.74%
Complexity 943 943
==========================================
Files 1121 1122 +1
Lines 93800 93946 +146
Branches 71124 71282 +158
==========================================
+ Hits 67301 67406 +105
- Misses 23863 23883 +20
- Partials 2636 2657 +21
🚀 New features to boost your workflow:
|
numinnex
reviewed
Mar 26, 2026
| pub struct ClientEntry { | ||
| /// The request number of the most recent committed request. | ||
| pub request: u64, | ||
| /// The cached reply for that request (header + body). |
Contributor
There was a problem hiding this comment.
Add an Notify primitive, to notify awaiting client that the respones is ready
364894a to
5ce819d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientsTableto the consensus layer implementing the VSR client-table ( based on VR Revisited, Section 4, Figure 2) for duplicate request detection and reply cachingon_request(both metadata and partitions planes) to check for duplicate/stale requests before entering the consensus pipelineon_ackto cache committed replies for re-sending on duplicatesmax_clients(8192) is exceededCloses #3022