Conversation
c0fc5c0 to
ac31fe9
Compare
…ire types Server binary handlers duplicated wire format logic from iggy_binary_protocol. Replace request decoding (ServerCommand enum + enum_dispatch + BytesSerializable) with direct WireDecode dispatch, and response encoding (mapper.rs) with WireEncode on wire response types. Handlers become standalone async functions. Fix CreateUserRequest/UpdatePermissionsRequest wire format: perm_len was written unconditionally but iggy_common only writes it when has_permissions == 1. Deleted: command.rs, macros.rs, mapper.rs, handlers/utils.rs, enum_dispatch dependency.
ac31fe9 to
35892b4
Compare
numinnex
approved these changes
Mar 26, 2026
mmodzelewski
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server binary handlers duplicated wire format logic from
iggy_binary_protocol. Replace request decoding (ServerCommand
enum + enum_dispatch + BytesSerializable) with direct WireDecode
dispatch, and response encoding (mapper.rs) with WireEncode on
wire response types. Handlers become standalone async functions.
Fix CreateUserRequest/UpdatePermissionsRequest wire format:
perm_len was written unconditionally but iggy_common only
writes it when has_permissions == 1.
Deleted: command.rs, macros.rs, mapper.rs, handlers/utils.rs,
enum_dispatch dependency.