fix(go): update stats field and its deserialization logic to align with rust SDK#3032
Open
chengxilo wants to merge 3 commits intoapache:masterfrom
Open
fix(go): update stats field and its deserialization logic to align with rust SDK#3032chengxilo wants to merge 3 commits intoapache:masterfrom
chengxilo wants to merge 3 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3032 +/- ##
============================================
- Coverage 71.74% 71.72% -0.03%
Complexity 930 930
============================================
Files 1121 1103 -18
Lines 93777 91606 -2171
Branches 71125 68920 -2205
============================================
- Hits 67284 65706 -1578
+ Misses 23856 23449 -407
+ Partials 2637 2451 -186
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Address #2964 (comment)
Rationale
The rust side now serializes threads_count, free_disk_space, and total_disk_space on the wire (in core/server/src/binary/mapper.rs), but the go Stats struct (foreign/go/contracts/stats.go) and its deserializer (foreign/go/binary_serialization/stats_serializer.go) don't read these fields.
(Yeah, I copied the comment) 😋
What changed?
Stats, also the tests.TcpStatsand update the function related to it asStatsis already enough for our logic.Statsdeserialization logic with reader introduced in feat(go): implement binary reader/writer #2986Local Execution
AI Usage