Conversation
It seems like github action needs to have specified pull request workflow. This commit sets workflow to act on "closed" and all default actions.
hubcio
force-pushed
the
fix_ci_release
branch
from
eb80cfa to
18836f9
Compare
spetz
approved these changes
Sep 8, 2023
ryerraguntla
referenced
this pull request
in ryerraguntla/iggy-1
Feb 23, 2026
…flow-again fix: hwloc linker error on macOS CI builds
mlevkov
added a commit
to mlevkov/iggy
that referenced
this pull request
Mar 21, 2026
Functional changes addressing hubcio's review feedback: apache#1 Consuming iterator: all 4 send methods now iterate `for message in messages` (owned) instead of `for message in &messages` with `.clone()` on payloads. Uses `std::mem::replace` to extract payload while keeping message intact for `build_envelope()`. apache#2 DRY refactor: extracted `send_per_message()` — shared per-message loop with circuit breaker, partial delivery accounting, and payload size enforcement. `send_individual()` and `send_raw()` are now thin closures over the shared method. apache#4 Pre-built HeaderMap: headers are parsed once in `open()` after validation, stored as `reqwest::header::HeaderMap`, and cloned per request in `send_with_retry()`. Removes `request_builder()` method. apache#5 UUID v8: `format_u128_as_uuid()` now uses `Uuid::new_v8()` to set proper RFC 4122 version/variant bits. Adds `uuid` dep with `v8` feature. apache#6 HashSet for success_status_codes: O(1) lookup in the hot path (`send_with_retry()`) instead of O(n) Vec scan. apache#7 Zero-alloc UUID: `Uuid::to_string()` uses stack-allocated formatting (resolved by apache#5's Uuid switch). apache#9 Forward iggy message headers: `build_envelope()` includes `iggy_headers` in metadata when `ConsumedMessage.headers` is present. Uses `to_string_value()` for human-readable key/value strings. apache#10 Success/transient overlap warning: `open()` warns when `success_status_codes` overlap with transient retry codes (429, 5xx). apache#11 Worst-case latency doc: `consume()` doc comment documents `batch_length * (max_retries + 1) * max_retry_delay` formula. 62 unit tests pass, zero clippy warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like github action needs to have
specified pull request workflow. This commit
sets workflow to act on "closed" and all default
actions.