JAMES-4146: Add support for proxy protocol in managesieve#2808
Merged
Conversation
felixauringer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that it is possible to configure proxy protocol for managesieve but the configuration is ignored.
This fixes that. I did not find any logic in managesieve that tries to act on the real client IP, so it is available now in the MDCContext but it is never used.
There is already a general
BasicChannelInboundHandlerwhich also decodes the proxy protocol, but as far as I understand, it is only used for SMTP. ManageSieve and IMAP both have their own InboundHandler.Find the Jira issue here.