Skip to content

MINOR: fix imports in AdminFenceProducersIntegrationTest#16342

Merged
jolshan merged 2 commits intoapache:3.7from
jolshan:fixImports
Jun 15, 2024
Merged

MINOR: fix imports in AdminFenceProducersIntegrationTest#16342
jolshan merged 2 commits intoapache:3.7from
jolshan:fixImports

Conversation

@jolshan
Copy link
Copy Markdown
Member

@jolshan jolshan commented Jun 14, 2024

The config files were moved after the 3.7 release.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlprat
Copy link
Copy Markdown
Contributor

jlprat commented Jun 14, 2024

Hi @jolshan I believe this same patch should be applied to the 3.8 branch. Am I right?

Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoardocomar
Copy link
Copy Markdown
Contributor

@jlprat no this is not needed for 3.8

@jlprat
Copy link
Copy Markdown
Contributor

jlprat commented Jun 14, 2024

Thanks! @edoardocomar

@edoardocomar
Copy link
Copy Markdown
Contributor

@jolshan if you agree, please add this commit to your PR
#16326
to tag the integration test as such

@edoardocomar
Copy link
Copy Markdown
Contributor

I tested this fix too LGTM - thanks @jolshan

@jolshan
Copy link
Copy Markdown
Member Author

jolshan commented Jun 14, 2024

@edoardocomar I can add the commit but it will also restart the build. Given this shouldn't alter code, I'm not sure if we still want to run all the tests.

…che#16326)

Add @tag("integration") to AdminFenceProducersIntegrationTest

Reviewers: Chris Egerton <chrise@aiven.io>
@jolshan
Copy link
Copy Markdown
Member Author

jolshan commented Jun 14, 2024

We had one version fail to build anyway, so I pushed the new commit. Should be good to merge once the job is done.

@jolshan jolshan merged commit b409973 into apache:3.7 Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants