KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage tool#16607
Merged
gharris1727 merged 3 commits intoapache:trunkfrom Jul 17, 2024
Merged
KAFKA-17148: Remove print MetaPropertiesEnsemble from kafka-storage tool#16607gharris1727 merged 3 commits intoapache:trunkfrom
gharris1727 merged 3 commits intoapache:trunkfrom
Conversation
chia7712
reviewed
Jul 16, 2024
| metaPropertiesEnsemble.verify(metaProperties.clusterId(), metaProperties.nodeId(), | ||
| util.EnumSet.noneOf(classOf[VerificationFlag])) | ||
|
|
||
| stream.println(s"metaPropertiesEnsemble=$metaPropertiesEnsemble") |
Member
There was a problem hiding this comment.
testFormatEmptyDirectory and testFormatSucceedsIfAllDirectoriesAreAvailable need to be updated for this change.
Member
Member
gharris1727
approved these changes
Jul 17, 2024
Contributor
gharris1727
left a comment
gharris1727
left a comment
There was a problem hiding this comment.
I confirmed that this prevents the line from being printed from the storage tool.
Contributor
|
Test failures appear unrelated. |
gharris1727
pushed a commit
to gharris1727/kafka
that referenced
this pull request
Jul 17, 2024
…ool (apache#16607) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
gharris1727
pushed a commit
to gharris1727/kafka
that referenced
this pull request
Jul 17, 2024
…ool (apache#16607) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
C0urante
pushed a commit
to C0urante/kafka
that referenced
this pull request
Jul 17, 2024
…ool (apache#16607) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…ool (apache#16607) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Greg Harris <greg.harris@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove print
MetaPropertiesEnsemblefrom kafka-storage tool.Committer Checklist (excluded from commit message)