MAJOR: Hotfix broken spotless config, adhere SSOT #21165 #21161 #21168
#21171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Pankraz76
commented
Dec 18, 2025
| skipProjects = [ ":jmh-benchmarks", ":trogdor" ] | ||
| skipConfigurations = [ "zinc" ] | ||
| } | ||
| apply plugin: 'com.diffplug.spotless' |
| dependsOn 'copyDependantLibs' | ||
| } | ||
|
|
||
| apply plugin: 'com.diffplug.spotless' |
| apply plugin: 'com.diffplug.spotless' | ||
| spotless { | ||
| scala { | ||
| target '**/*.scala' |
| scala { | ||
| target '**/*.scala' | ||
| scalafmt("$versions.scalafmt").configFile('../../checkstyle/.scalafmt.conf').scalaMajorVersion(versions.baseScala) | ||
| licenseHeaderFile '../../checkstyle/java.header', 'package' |
Author
There was a problem hiding this comment.
relative kind of fragile (error prone).
Author
|
im not sure if major is too much and just name it again minor, but this kind of non trivial change as if enforces at least to make follow up activating scala again doing continuing changes aligning the code. |
Pankraz76
changed the title
Pankraz76
changed the title
spotless config, adhere SSOT #21165 #21161 #21168
Pankraz76
force-pushed
the
fix-NoDoubleBraceInitialization-fix-spot
branch
from
f0759fc to
e877320
Compare
…ache#21161 apache#21168 Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
fix-NoDoubleBraceInitialization-fix-spot
branch
from
e877320 to
365838b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAJOR: Hotfix broken
spotlessconfig, adhereSSOT#21165 #21161 #21168According to the PR, the Spotless configuration appears to be broken. A closer inspection shows that it is significantly out of sync and not behaving as expected.
This change fixes the Spotless setup, restores correct formatting for functional Scala code, and addresses related issues across the codebase. The goal is to re-establish consistent conventions, follow the Single Source of Truth (SSOT) principle, and ensure a clean, robust codebase that supports a healthy development workflow.
Related PR:
Merge strategy suggestion
It is recommended to merge this PR as a minimal, stabilizing fix, focusing on restoring baseline correctness (including the Python-related fixes) and unblocking the build.
Any currently disabled or partially applied Spotless rules should be re-enabled in dedicated follow-up PRs, where formatting can be incrementally reintroduced, validated, and fully fixed. This allows safer iteration and clearer review while ensuring the Spotless formatting rules are ultimately applied as intended.