KAFKA-19755 Move KRaftClusterTest from core module to server module [3/4] #21175
Conversation
github-actions
bot
added
triage
# Conflicts: # core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala # server/src/test/java/org/apache/kafka/server/KRaftClusterTest.java
|
@DL1231 Could you merge trunk in to trigger CI again? |
server/src/test/java/org/apache/kafka/server/KRaftClusterTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/kafka/server/KRaftClusterTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/kafka/server/KRaftClusterTest.java
Outdated
Show resolved
Hide resolved
| values.get(resource).get(); | ||
| return ApiError.NONE; | ||
| } catch (ExecutionException e) { | ||
| return ApiError.fromThrowable(e.getCause()); |
There was a problem hiding this comment.
ApiError.fromThrowable already unwraps the exception, so we don't need to call getCause explictly
| } | ||
| } | ||
|
|
||
| private void assertListEquals(List<ApiError> expected, List<ApiError> actual) { |
There was a problem hiding this comment.
Could we use assertIterableEquals(expected, actual); here instead?
There was a problem hiding this comment.
The reason I've opted for the custom assertListEquals method is that the incrementalAlterConfigs API does not guarantee the order of the ApiError objects in its returned list.
As you know, assertIterableEquals performs a strict comparison that requires the elements in both iterables to be in the exact same sequence.
The current assertListEquals implementation correctly verifies that the actual list contains all the expected errors and no unexpected ones, but it does so without being sensitive to their order.
|
|
||
| for (int i = 0; i < 3; i++) { | ||
| int brokerId = i; | ||
| TestUtils.waitForCondition( |
There was a problem hiding this comment.
Can it be replaced by cluster.waitForReadyBrokers();?
server/src/test/java/org/apache/kafka/server/KRaftClusterTest.java
Outdated
Show resolved
Hide resolved
2 participants
Move KRaftClusterTest from core module to server module.
Rewrite
Reviewers: Chia-Ping Tsai chia7712@gmail.com