Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Introduce github actions for CI#47

Merged
sharanf merged 2 commits intoapache:masterfrom
PolideaInternal:add-github-actions
Oct 16, 2020
Merged

Introduce github actions for CI#47
sharanf merged 2 commits intoapache:masterfrom
PolideaInternal:add-github-actions

Conversation

@turbaszek
Copy link
Copy Markdown
Member

@turbaszek turbaszek commented Oct 10, 2020

This is a followup PR for #44

@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 10, 2020

@sharanf can we please ask infra team to turn on Github Actions for Apache Kibble project? It cannot be configured via .asf.yaml file.

The CI seems to be working on my fork:
https://github.com/PolideaInternal/kibble/runs/1235577492

@sharanf sharanf requested a review from Humbedooh October 10, 2020 14:19
@sharanf
Copy link
Copy Markdown
Contributor

sharanf commented Oct 10, 2020 •
edited
Loading

@turbaszek I have requested a review from @Humbedooh who is part of the ASF Infra team so if there is anything missing I am sure he will let us know :-)

@turbaszek turbaszek force-pushed the add-github-actions branch 2 times, most recently from f64220b to 19a9bc4 Compare October 10, 2020 14:31
michalslowikowski00
michalslowikowski00 approved these changes Oct 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@michalslowikowski00 michalslowikowski00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :)

@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 12, 2020

@Humbedooh any update on the possibility of turning on Github Actions for the Apache Kibble project?

@Humbedooh
Copy link
Copy Markdown
Member

Humbedooh commented Oct 12, 2020

GitHub actions should already be enabled for Kibble

@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 12, 2020

GitHub actions should already be enabled for Kibble

Hm, interesting. @Humbedooh do we "Allow all actions" or only "Allow local actions only"? The yaml is ok as the CI is running on my fork:
https://github.com/PolideaInternal/kibble/actions

@Humbedooh
Copy link
Copy Markdown
Member

Humbedooh commented Oct 12, 2020

Its allow all

@turbaszek turbaszek closed this Oct 12, 2020
@turbaszek turbaszek reopened this Oct 12, 2020
@turbaszek turbaszek force-pushed the add-github-actions branch 2 times, most recently from 6989159 to 6cb5ae0 Compare October 12, 2020 17:05
@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 12, 2020

@TobKed you are GA expert, any ideas why GA doesn't want to start? 😄

@turbaszek turbaszek force-pushed the add-github-actions branch 5 times, most recently from 2c206d1 to 062b2ae Compare October 12, 2020 17:37
@turbaszek turbaszek mentioned this pull request Oct 12, 2020
Closed
@TobKed
Copy link
Copy Markdown

TobKed commented Oct 12, 2020

@TobKed you are GA expert, any ideas why GA doesn't want to start? 😄

I am not 100% sure but I think it will not run before merging. @Humbedooh is it possible that "Allow local actions only" is overridden by organization settings which may be "Allow all actions"?

@Humbedooh
Copy link
Copy Markdown
Member

Humbedooh commented Oct 12, 2020

Both org and local setting is "allow all", so I dunno. But we'll see if it'll run once we merge, I guess :)

@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 12, 2020

Both org and local setting is "allow all", so I dunno. But we'll see if it'll run once we merge, I guess :)

Yup, here's reply from Github support:

I'm showing that the forked repository has GitHub Actions workflow files, but I'm not seeing any on the main repository.

You will need to merge your change that adds the ci.yml file to the main repository before it will be able to start running the action when you perform pull_request.

@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 12, 2020

@Humbedooh so it seems we need to merge it to see CI up and running 🤷‍♂️ This will require a follow-up PR that will make CI green - I can make it asap after merging this

Humbedooh
Humbedooh reviewed Oct 13, 2020
View reviewed changes
CONTRIBUTING.md Outdated
## Code Quality

Apache Kibble project is using [pre-commits](https://pre-commit.com) to ensure the quality of the code.
We encourage you to use pre-commits, but it's not a required to contribute. Every change is checked
Copy link
Copy Markdown
Member

@Humbedooh Humbedooh Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be either it's not required in order to contribute or it's not a requirement in order to contribute.

@turbaszek turbaszek requested a review from Humbedooh October 13, 2020 07:33
@turbaszek
Copy link
Copy Markdown
Member Author

turbaszek commented Oct 14, 2020

Hi all, is there anything that should be done to get this PR merged? @Humbedooh @sharanf

@sharanf
Copy link
Copy Markdown
Contributor

sharanf commented Oct 16, 2020

Hi @turbaszek as @Humbedooh has already given feedback on this I am happy to merge it.

@sharanf sharanf merged commit b371d80 into apache:master Oct 16, 2020
turbaszek added a commit to PolideaInternal/kibble that referenced this pull request Oct 17, 2020
@turbaszek
Introduce github actions for CI (apache#47)
5e22739 
* Introduce github actions for CI

* fixup! Introduce github actions for CI
turbaszek added a commit to PolideaInternal/kibble that referenced this pull request Oct 17, 2020
@turbaszek
Introduce github actions for CI (apache#47)
dc04033 
* Introduce github actions for CI

* fixup! Introduce github actions for CI
@TobKed TobKed deleted the add-github-actions branch October 19, 2020 08:52
@turbaszek turbaszek mentioned this pull request Oct 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Humbedooh Humbedooh Awaiting requested review from Humbedooh

1 more reviewer

@michalslowikowski00 michalslowikowski00 michalslowikowski00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@turbaszek @sharanf @Humbedooh @TobKed @michalslowikowski00