KNOX-3327: Support periodic refresh of gateway configuration#1235
Merged
Conversation
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit e21de9c. ♻️ This comment has been updated with latest results. |
hanicz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-1234 - Support periodic refresh of gateway configuration
What changes were proposed in this pull request?
This PR introduces the ability for the Knox Gateway to periodically refresh its configuration from a specific reloadable file (gateway-reloadable.xml). This allows administrators to modify certain gateway-level configurations at runtime
without restarting the entire Gateway process.
Key changes include:
GatewayConfigImplto includegateway-reloadable.xmlin the prioritized list of configuration files.gateway.config.refresh.interval(defaulting to 10,000ms) to control how often the gateway checks for updates.How was this patch tested?
The patch was tested using new and updated automated unit tests:
GatewayConfigImplTest.testGetConfigRefreshInterval: Verified that the refresh interval configuration is correctly parsed.GatewayConfigImplTest.testReloadableConfigLoading: Verified that properties defined ingateway-reloadable.xmlare correctly loaded into the configuration object upon initialization.GatewayServerTest.testRefreshGatewayConfig: Verified the logic that monitors file timestamps. Confirmed that:Steps to run tests:
mvn test -Dtest=GatewayConfigImplTest,GatewayServerTest -pl gateway-serverIntegration Tests
Unit tests were added to gateway-server to cover the new functionality. These tests use TemporaryFolder and manual XML generation to simulate file system changes and verify the reload behavior.
UI changes
N/A