[CI] Add current ip address, long hostname and short hostname to /etc/hosts - #1735
Closed
yaooqinn wants to merge 3 commits into
Closed
[CI] Add current ip address, long hostname and short hostname to /etc/hosts#1735yaooqinn wants to merge 3 commits into
yaooqinn wants to merge 3 commits into
Conversation
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
============================================
+ Coverage 59.51% 59.53% +0.02%
- Complexity 233 234 +1
============================================
Files 268 268
Lines 13305 13305
Branches 1688 1688
============================================
+ Hits 7918 7921 +3
+ Misses 4709 4708 -1
+ Partials 678 676 -2
Continue to review full report at Codecov.
|
ulysses-you
approved these changes
Jan 12, 2022
Member
Author
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fixes reverse DNS lookup for the current hostname. This makes GitHub Actions flacky currently.
See apache/pulsar#10232 and apache/pulsar#10233 for more details.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request