[KYUUBI #479][TEST][FOLLOWUP] Bind host to 127.0.0.1 in initialize#489
Closed
turboFei wants to merge 3 commits into
Closed
[KYUUBI #479][TEST][FOLLOWUP] Bind host to 127.0.0.1 in initialize#489turboFei wants to merge 3 commits into
turboFei wants to merge 3 commits into
Conversation
Member
Author
|
yaooqinn
approved these changes
Apr 6, 2021
ulysses-you
reviewed
Apr 7, 2021
| @@ -35,9 +35,9 @@ trait KyuubiFunSuite extends FunSuite | |||
| with ThreadAudit | |||
| with Logging { | |||
| // scalastyle:on | |||
Contributor
There was a problem hiding this comment.
not relate about this pr, why here forbid scalastyle check ?
Member
There was a problem hiding this comment.
The forbid is necessary because of the rule:
<check customId="funsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
<parameters><parameter name="regex">^FunSuite[A-Za-z]*$</parameter></parameters>
<customMessage>Tests must extend org.apache.kyuubi.KyuubiFunSuite instead.</customMessage>
</check>
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 81.70% 81.70%
=======================================
Files 116 116
Lines 4247 4247
Branches 514 514
=======================================
Hits 3470 3470
Misses 498 498
Partials 279 279 Continue to review full report at Codecov.
|
Member
|
There are some issues on GitHub Action this days, and since travis-CI passed, I will merge it. Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Bind host to 127.0.0.1 in initialize phase, so that even some suite override the beforeAll method and invoke super.beforeAll after start service.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request