Skip to content

Initial fixes for log4j - #381

Closed
dacort wants to merge 1 commit into
masterfrom
fix/log4j
Closed

Initial fixes for log4j#381
dacort wants to merge 1 commit into
masterfrom
fix/log4j

Conversation

@dacort

@dacort dacort commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Upgrading log4j v1 to log4j bridge for LIVY-878.

How was this patch tested?

Local tests

Items left todo

Log4j is still included at compile time in the following modules

  • livy-integration-test:compile
  • livy-coverage-report:compile
  • livy-assembly:compile
  • livy-server:compile

@codecov-commenter

codecov-commenter commented Dec 28, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.53%. Comparing base (ff1f65b) to head (35a2a28).
⚠️ Report is 69 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #381      +/-   ##
============================================
- Coverage     28.24%   27.53%   -0.71%     
+ Complexity      359      354       -5     
============================================
  Files           103      103              
  Lines          5948     6061     +113     
  Branches        899      954      +55     
============================================
- Hits           1680     1669      -11     
- Misses         3921     4070     +149     
+ Partials        347      322      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dacort

dacort commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favor of #392

@dacort dacort closed this Mar 13, 2023
@dacort
dacort deleted the fix/log4j branch April 26, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants