Fix NPE in PatternProcessor for the UNIX pattern#2350
Merged
Conversation
ppkarwasz
force-pushed
the
fix/2346_unix_millis_date_pattern
branch
from
48ebcf9 to
7aa0277
Compare
vy
approved these changes
Mar 6, 2024
vy
added
bug
Closes 2346. The constructor of `PatternProcessor` fails if the date pattern is `UNIX` and `UNIX_MILLIS`: `DatePatterConverter#getPattern()` returns intentionally `null` in those cases.
ppkarwasz
force-pushed
the
fix/2346_unix_millis_date_pattern
branch
from
7aa0277 to
054a4f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2346.
The constructor of
PatternProcessorfails if the date pattern isUNIXandUNIX_MILLIS:DatePatterConverter#getPattern()returns intentionallynullin those cases.