Skip to content

add License headers as a first-class review category #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
May 17, 2026
Merged

add License headers as a first-class review category #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .claude/skills/pr-management-code-review/criteria.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ The canonical category list:
- Database / query correctness
- Code quality
- Third-party license compliance
- License headers
- Testing
- API correctness
- UI (React/TypeScript)
Expand Down
18 changes: 11 additions & 7 deletions .claude/skills/pr-management-code-review/review-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,17 @@ match against are:
2. **Database / query correctness**
3. **Code quality**
4. **Third-party license compliance**
5. **Testing**
6. **API correctness**
7. **UI (React/TypeScript)**
8. **Generated files**
9. **AI-generated code signals**
10. **Per-area `AGENTS.md` rules** — anything specific to the
touched tree (the per-PR `AGENTS.md` discovery in Step 2).
5. **License headers**
6. **Testing**
7. **API correctness**
8. **UI (React/TypeScript)**
9. **Generated files**
10. **AI-generated code signals**
11. **Quality signals to check**
12. **Commits and PRs** (newsfragments, commit messages, tracking issues)
13. **Security model**
14. **Per-area `AGENTS.md` rules** — anything specific to the
touched tree (the per-PR `AGENTS.md` discovery in Step 2).

For each finding, record:

Expand Down
1 change: 1 addition & 0 deletions projects/_template/pr-management-code-review-criteria.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ These are used when the skill links out per-finding.
| Architecture boundaries | `https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#architecture-boundaries` |
| Database / query correctness | `https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#database-and-query-correctness` |
| Code quality | `https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#code-quality-rules` |
| License headers | `https://www.apache.org/legal/src-headers.html` |
| Testing | `https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#testing-requirements` |
| API correctness | `https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#api-correctness` |
| UI (React/TypeScript) | `https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#ui-code-reacttypescript` |
Expand Down
Loading