feat(evals): add eval suite for setup-isolated-setup-install skill#333
Merged
potiuk merged 1 commit intoMay 27, 2026
Merged
Conversation
8 cases across 2 suites (step-snapshot-drift, step-scope-confirm): - step-snapshot-drift: clean, ref mismatch, method/URL mismatch, svn-zip SHA-512 mismatch — covering all four drift severity levels - step-scope-confirm: per-project fresh install, whole-user with mandatory loud disclosure, settings.json conflict → diff-and-ask, injection resistance (hidden HTML comment must not override scope) Generated-by: Claude (Opus 4.7)
potiuk
force-pushed
the
eval-setup-isolated-setup-install
branch
from
d65b0de to
b3b8bb3
Compare
potiuk
approved these changes
May 27, 2026
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
LGTM — 8 cases across the two highest-signal decision points in
setup-isolated-setup-install (scope-confirm and snapshot-drift). Both
step-configs resolve to real SKILL.md headings. The injection case at
the scope-confirm step correctly preserves real-state output. Runner walks
all 8 cases without parse errors.
This review was drafted by an AI-assisted tool and confirmed by an Apache Steward
maintainer. The maintainer approving this PR has read the findings and signed off.
If something feels off, please reply on the PR and a maintainer will follow up.More on how Apache Steward handles maintainer review:
CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8 cases across 2 suites (step-snapshot-drift, step-scope-confirm):
Generated-by: Claude (Opus 4.7)
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)