Skip to content

refactor(skills): rename to type-what_you_operate_on-action convention#35

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:refactor/rename-skills-type-what-action
May 3, 2026
Merged

refactor(skills): rename to type-what_you_operate_on-action convention#35
potiuk merged 1 commit into
apache:mainfrom
potiuk:refactor/rename-skills-type-what-action

Conversation

@potiuk

@potiuk potiuk commented May 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Standardise 17 skill folder names + 4 adopter-config scaffold files on a type-what_you_operate_on-action shape (follow-up to refactor(skills): rename skills with category prefixes (setup-/security-) #31's category-prefix rename). 62 files touched, 488/488 ins/del — pure rename, no semantic change.
  • Setup family: setup-{thing}-{action} (e.g. setup-isolated-setup-install was setup-secure-config). secure-config becomes isolated-setup to more accurately name what's being installed.
  • Security family: security-{issue,cve}-{action} with singular noun (issuesissue).
  • PR family: pr-management-{action} — type prefix promoted from plain pr- to pr-management-.
  • Adopter-config scaffolds in projects/_template/ renamed to match.

Full rename table

Setup family

Old New
setup-secure-config setup-isolated-setup-install
setup-verify-secure-config setup-isolated-setup-verify
setup-update-secure-config setup-isolated-setup-update
setup-upgrade-steward setup-steward-upgrade
setup-verify-steward setup-steward-verify
setup-sync-shared-config setup-shared-config-sync

Security family

Old New
security-import-issues security-issue-import
security-import-issues-from-md security-issue-import-from-md
security-import-issue-from-pr security-issue-import-from-pr
security-sync-issues security-issue-sync
security-fix-issue security-issue-fix
security-allocate-cve security-cve-allocate
security-deduplicate-issues security-issue-deduplicate
security-invalidate-issue security-issue-invalidate

PR family

Old New
pr-triage pr-management-triage
pr-stats pr-management-stats
pr-maintainer-review pr-management-code-review

Adopter-config scaffolds

Old New
pr-triage-config.md pr-management-config.md
pr-triage-comment-templates.md pr-management-triage-comment-templates.md
pr-triage-ci-check-map.md pr-management-triage-ci-check-map.md
pr-maintainer-review-criteria.md pr-management-code-review-criteria.md

Breaking change

Adopters using the framework via submodule + symlinks (the airflow-s tracker; the in-flight apache/airflow#66283 adopter-config PR) need to:

  1. Bump their submodule pointer to the merge commit of this PR.
  2. Rename any <project-config>/ files that referenced the old scaffold names.
  3. Update any project-side references to old skill names.

For apache/airflow#66283 specifically: the four .apache-steward/pr-triage-*.md and .apache-steward/pr-maintainer-review-criteria.md files will need to be renamed during the next rebase — non-blocking for this PR since #66283 is unmerged and the user is redesigning that adoption mechanism anyway.

Test plan

  • Claude Code discovers all renamed skills (live-change detection picked them up in-session)
  • No bare references to old names remain in tracked files (grep audit)
  • No double-prefix or substring collisions
  • Pre-commit hooks pass locally (markdownlint, typos, doctoc, check-placeholders)
  • CI link-check (lychee) passes
  • Reviewer eyeballs the table for awkward double-noun cases (setup-isolated-setup-* is intentional but verbose)

🤖 Generated with Claude Code

Standardise the 17 skill folder names + 4 adopter-config scaffold
files on `type-what_you_operate_on-action` for consistency and to
make the responsible noun + verb visible at a glance.

Setup family — `setup-{thing}-{action}`:

  setup-secure-config            → setup-isolated-setup-install
  setup-verify-secure-config     → setup-isolated-setup-verify
  setup-update-secure-config     → setup-isolated-setup-update
  setup-upgrade-steward          → setup-steward-upgrade
  setup-verify-steward           → setup-steward-verify
  setup-sync-shared-config       → setup-shared-config-sync

(`secure-config` becomes `isolated-setup` to more accurately name
what is being installed — an isolated agent setup, not just a
secure config.)

Security family — `security-{issue,cve}-{action}`, singular noun:

  security-import-issues          → security-issue-import
  security-import-issues-from-md  → security-issue-import-from-md
  security-import-issue-from-pr   → security-issue-import-from-pr
  security-sync-issues            → security-issue-sync
  security-fix-issue              → security-issue-fix
  security-allocate-cve           → security-cve-allocate
  security-deduplicate-issues     → security-issue-deduplicate
  security-invalidate-issue       → security-issue-invalidate

PR family — `pr-management-{action}` (type prefix promoted from
plain `pr-` to `pr-management-` to disambiguate from
`pr` as an enum value elsewhere):

  pr-triage             → pr-management-triage
  pr-stats              → pr-management-stats
  pr-maintainer-review  → pr-management-code-review

Adopter-config scaffolds renamed to match:

  pr-triage-config.md                  → pr-management-config.md
  pr-triage-comment-templates.md       → pr-management-triage-comment-templates.md
  pr-triage-ci-check-map.md            → pr-management-triage-ci-check-map.md
  pr-maintainer-review-criteria.md     → pr-management-code-review-criteria.md

62 files touched, 488/488 ins/del — pure rename. Cross-references
updated everywhere (README, AGENTS.md, CONTRIBUTING.md,
secure-agent-setup.md, secure-agent-internals.md,
projects/_template/, .claude/skills/*/, tools/, generate-cve-json
docstrings). doctoc TOCs regenerated.

Generated-by: Claude Code (Claude Opus 4.7)
@potiuk potiuk merged commit 748d360 into apache:main May 3, 2026
7 checks passed
potiuk added a commit that referenced this pull request May 4, 2026
…sedes #30) (#44)

* docs: enable markdownlint MD040 and tag all fenced code blocks

Follow-up to #18. Flips MD040 from `false` to `true` and tags the 64
previously untagged fences across the tree.

Most fences ended up `text` (MCP call sketches, URL examples, dir
trees, plain output, commit trailers). 3 got `html` for HTML-comment
idempotency markers and the <details> envelope, 3 `markdown` for the
AI-disclosure block and rollup body samples, 1 `yaml` for the
subagent return block in sync-security-issue.

One nested-fence case in allocate-cve/SKILL.md needed the outer
fence promoted from 3 to 4 backticks so the inner 3-backtick block
renders as an actual nested code block instead of breaking the outer
one.

Signed-off-by: André Ahlert <andre@aex.partners>

* docs: extend MD040 tagging to skills added since #30

#30 was opened against an earlier tree state; the pr-management
skill family (lifted in #33, renamed to type-what-action in
#35) added 9 new skill supporting files with 20 untagged
fences that fail markdownlint MD040 once it's enabled.

This commit applies the same tagging convention #30 established
for the security family + tools to the new pr-management files:

  pr-management-triage/fetch-and-batch.md     1 fence
  pr-management-triage/comment-templates.md   2 fences  → markdown
  pr-management-triage/interaction-loop.md    4 fences  → text (UI mockups)
  pr-management-triage/workflow-approval.md   2 fences  → text (UI mockups)
  pr-management-stats/fetch.md                3 fences  → text (search queries)
  pr-management-stats/render.md               3 fences  → text (output samples)
  pr-management-stats/classify.md             3 fences  → text (pseudocode)
  pr-management-code-review/review-flow.md    1 fence   → text (CLI mockup)
  pr-management-code-review/prerequisites.md  1 fence   → text (HTTP error)

Most fences ended up `text` (the same catch-all #30's commit
message used for "MCP call sketches, URL examples, dir trees,
plain output"). Two `markdown` fences in
`pr-management-triage/comment-templates.md` because the
content is a markdown link / list item example that GitHub
should render as markdown.

prek run --all-files clean. MD040 reports zero violations
across the tree.

Generated-by: Claude Code (Claude Opus 4.7)

---------

Signed-off-by: André Ahlert <andre@aex.partners>
Co-authored-by: André Ahlert <andre@aex.partners>
@andreahlert andreahlert added the mode:platform Substrate / infra — not a mode (sandbox, CI, validators) label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode:platform Substrate / infra — not a mode (sandbox, CI, validators)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants