Skip to content

fix(spec-validator): add dev dependency group and fix check-#9 comment#560

Merged
potiuk merged 1 commit into
apache:mainfrom
justinmclean:spec-validator-dev-group
Jun 26, 2026
Merged

fix(spec-validator): add dev dependency group and fix check-#9 comment#560
potiuk merged 1 commit into
apache:mainfrom
justinmclean:spec-validator-dev-group

Conversation

@justinmclean

Copy link
Copy Markdown
Member

Summary

Add [dependency-groups] dev = [pytest, ruff] to
tools/spec-validator/pyproject.toml so that the standard monorepo invocation
uv run --project tools/spec-validator --group dev pytest tools/spec-validator/tests/
works from the repo root, matching the pattern established by tools/skill-and-tool-validator (asf-coupling-lint) and documented in the module docstring.

Also fix a copy-paste comment mislabelling check #9 (validation-path existence as check #8 — SPDX header validation is check #8.

Generated-by: Claude (Opus 4.7)

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other:

Test plan

  • prek run --all-files passes
  • For Python packages touched: uv run pytest / ruff check / mypy passes
  • For Groovy bridges touched: command-line invocation tested end-to-end
  • For skill changes: eval suite passes for the affected skill
    (PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)
  • For skill behaviour changes: a new or updated eval fixture is included in this PR
    (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
  • Other:

…comment

Add [dependency-groups] dev = [pytest, ruff] to
tools/spec-validator/pyproject.toml so that the standard
monorepo invocation
  uv run --project tools/spec-validator --group dev pytest tools/spec-validator/tests/
works from the repo root, matching the pattern established by
tools/skill-and-tool-validator (asf-coupling-lint) and documented in
the module docstring.

Also fix a copy-paste comment mislabelling check apache#9 (validation-path
existence as check apache#8 — SPDX header validation is check apache#8.

Generated-by: Claude (Opus 4.7)
EOF
)
@justinmclean justinmclean self-assigned this Jun 26, 2026
@potiuk potiuk merged commit b9678e7 into apache:main Jun 26, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants