feat(validator): add adapter authoring smoke check for contract:* tools#651
Merged
potiuk merged 2 commits intoJun 30, 2026
Merged
Conversation
Add a SOFT advisory check (aspect apache#11) to skill-and-tool-validator that verifies every contract:* adapter tool README declares the three authoring fields the adapter contract requires: credential/privacy handling, supported operations, and adopter config keys. All three checks are SOFT so legacy adapters can be brought into compliance deliberately without blocking unrelated changes. Twelve advisories fire on the current tree; exit code stays 0. New TestValidateAdapterAuthoring class adds 13 targeted tests. Generated-by: Claude (Opus 4.7)
potiuk
approved these changes
Jun 30, 2026
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Nice! I was thinking about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)