fix(pr-management-triage): generalise security-list coupling and anonymise historical dev-list reference#696
Merged
potiuk merged 2 commits intoJul 3, 2026
Conversation
…ymise historical dev-list reference Low-confidence asf-coupling pass (spec-loop work item apache#4). - comment-templates.md: replace hardcoded `security@apache.org` with `<security-list>` placeholder; remove ASF-specific URL from security vulnerability-handling prose; remove internal "dev@ thread with Elad" cross-reference - rationale.md: anonymise motivating-problem paragraph — project-specific mailing list name and individual names replaced with generic phrasing - SKILL.md: remove "dev@ thread with Elad" reference from triage_feedback_channel description - specs/project-agnosticism.md: extend Known Gaps entry to document the specific fixes made in this pass The validator already produces 0 asf-coupling warnings (org-scoped skills are suppressed by the `organization: ASF` frontmatter added in 0073ae8). The real coupling was in sub-documents not checked by the validator — `comment-templates.md` is posted verbatim to GitHub PRs, so a hardcoded `security@apache.org` was a genuine blocker for non-ASF adopters. `<security-list>` resolves from `<project-config>/project.md` → `mailing_lists.security` at run time. Generated-by: Claude (Opus 4.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
security@apache.orgwith<security-list>placeholder; remove ASF-specific URL from security vulnerability-handling prose; remove internal "dev@ thread with Elad" cross-referenceThe validator already produces 0 asf-coupling warnings (org-scoped skills are suppressed by the
organization: ASFfrontmatter added in 0073ae8). The real coupling was in sub-documents not checked by the validator —comment-templates.mdis posted verbatim to GitHub PRs, so a hardcodedsecurity@apache.orgwas a genuine blocker for non-ASF adopters.<security-list>resolves from<project-config>/project.md→mailing_lists.securityat run time.Generated-by: Claude (Opus 4.7)
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)