Skip to content

[MPOM-429] Support develop with JDK 21 (palantirJavaFormat update)#135

Merged
slachiewicz merged 3 commits intoapache:masterfrom
tisonkun:patch-1
Oct 2, 2023
Merged

[MPOM-429] Support develop with JDK 21 (palantirJavaFormat update)#135
slachiewicz merged 3 commits intoapache:masterfrom
tisonkun:patch-1

Conversation

@tisonkun
Copy link
Copy Markdown
Member

@tisonkun tisonkun commented Sep 22, 2023

slawekjaranowski
slawekjaranowski reviewed Sep 23, 2023
View reviewed changes
Comment thread pom.xml
slawekjaranowski
slawekjaranowski reviewed Sep 23, 2023
View reviewed changes
Comment thread pom.xml
@slawekjaranowski
Copy link
Copy Markdown
Member

slawekjaranowski commented Sep 23, 2023

I would like to wait for fix in spotless: diffplug/spotless#1822

If no before next release of parents we can consider it

@gnodet gnodet mentioned this pull request Sep 26, 2023
Closed
@slachiewicz slachiewicz changed the title Support develop with JDK 21 [MPOM-429] Support develop with JDK 21 (palantirJavaFormat update) Oct 1, 2023
@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Oct 2, 2023

Thanks for your review and suggestion!

We can still use this patch now as diffplug/spotless#1822 is unresolved yet.

@slachiewicz
Copy link
Copy Markdown
Member

slachiewicz commented Oct 2, 2023

Yes, I think patching spotless may take some more time.

@slachiewicz slachiewicz merged commit b2271de into apache:master Oct 2, 2023
@slachiewicz slachiewicz added the bug Something isn't working label Oct 2, 2023
@tisonkun tisonkun deleted the patch-1 branch October 2, 2023 12:29
@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Oct 2, 2023 •
edited
Loading

May I ask the release plan including this patch? I create this patch due to my project (hawkeye) want to upgrade to be compatible with JDK 21 dev :D

@slawekjaranowski
Copy link
Copy Markdown
Member

slawekjaranowski commented Oct 2, 2023

@tisonkun - Just out of curiosity - how this project impact on your project?
It is only used by Apache Maven projects as our parents.

@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Oct 2, 2023

Oops. It's not hawkeye where I can pin dependencies by myself and doesn't inherit the MPOM...

I forget where I come from now 🤣

@tisonkun
Copy link
Copy Markdown
Member Author

tisonkun commented Oct 4, 2023

@slawekjaranowski I encountered it again and remembered. I met this issue from Apache Curator who inherited this pom.

@slawekjaranowski slawekjaranowski mentioned this pull request Oct 11, 2023
Merged
@gnodet gnodet added this to the MAVEN-41 milestone Oct 16, 2023
@jira-importer
Copy link
Copy Markdown

jira-importer commented Mar 6, 2025

Resolve #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

MAVEN-41

Development

Successfully merging this pull request may close these issues.

5 participants

@tisonkun @slawekjaranowski @slachiewicz @jira-importer @gnodet