Skip to content

system/gcov: enhance gcov#2650

Merged
xiaoxiang781216 merged 3 commits into
apache:masterfrom
W-M-R:gcov
Oct 9, 2024
Merged

system/gcov: enhance gcov#2650
xiaoxiang781216 merged 3 commits into
apache:masterfrom
W-M-R:gcov

Conversation

@W-M-R

@W-M-R W-M-R commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Summary

  1. supports generating device-side code coverage
  2. adjust gcov configuration name
  3. deal compile warming

Impact

Testing

Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
@nuttxpr

nuttxpr commented Oct 8, 2024

Copy link
Copy Markdown

[Experimental Bot, please feedback here]

This PR summary is missing crucial information to determine if it meets NuttX requirements.

Missing Information:

  • Specifics on the change:
    • What "device-side code coverage" means and how it's implemented.
    • How the "gcov configuration name" is adjusted and why.
    • What "compile warnings" are addressed and how.
  • Impact details: ALL impact sections are empty. We need to understand:
    • What features are added/changed and how users are affected.
    • Build process changes, hardware/architecture implications.
    • Documentation needs, security considerations, compatibility impacts.
  • Testing Context:
    • What build hosts and target environments were used for verification?
    • The provided testing log sections are empty. Actual logs are needed.

To meet NuttX requirements, the PR needs to:

  1. Expand the Summary: Provide clear, concise explanations of each change.
  2. Complete the Impact section: Address ALL bullet points with specifics.
  3. Include Testing Details: Specify environments and provide REAL testing logs demonstrating the changes' effects.

gcov.c:61:6: warning: 'path' may be used uninitialized [-Wmaybe-uninitialized]
   61 |   if (path == NULL || access(path, F_OK) != 0 || atoi(strip) <= 0)
      |      ^
gcov.c: In function 'gcov_main':
gcov.c:79:19: note: 'path' was declared here
   79 |   FAR const char *path;

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
@cederom

cederom commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

CI errors, restarted :-)

@cederom

cederom commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Still CI errors :\

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

Still CI errors :\

since it depends on apache/nuttx#13965, let's merge both together.

@xiaoxiang781216 xiaoxiang781216 merged commit a2964c7 into apache:master Oct 9, 2024
@W-M-R W-M-R deleted the gcov branch October 10, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants