Skip to content

Fix telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared#2716

Merged
GUIDINGLI merged 1 commit into
apache:masterfrom
xiaoxiang781216:telnetd
Oct 14, 2024
Merged

Fix telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared#2716
GUIDINGLI merged 1 commit into
apache:masterfrom
xiaoxiang781216:telnetd

Conversation

@xiaoxiang781216

@xiaoxiang781216 xiaoxiang781216 commented Oct 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

telnetd.c: In function 'telnetd_main':
Error: telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared (first use in this function); did you mean 'CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY'?
   57 |     CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY

Impact

Kconfig

Testing

ci

@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Oct 13, 2024
Closed
@xiaoxiang781216 xiaoxiang781216 force-pushed the telnetd branch 2 times, most recently from 4b57d89 to 093efe3 Compare October 13, 2024 14:01
xiaoxiang781216 added a commit to xiaoxiang781216/nuttx-upstream that referenced this pull request Oct 13, 2024
@xiaoxiang781216
boards: Remove CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE from some defc…
858dc82 
…onfig

since the value is default after apache/nuttx-apps#2716

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Oct 13, 2024
Closed
@xiaoxiang781216 xiaoxiang781216 changed the title system/telnetd: Let SYSTEM_TELNETD depends on SYSTEM_NSH Fix telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared Oct 13, 2024
@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Oct 13, 2024
Merged
@xiaoxiang781216
Fix telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' …
900b2c0 
…undeclared

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@lupyuen lupyuen requested a review from cederom October 13, 2024 15:15
cederom
cederom approved these changes Oct 13, 2024
View reviewed changes

@cederom cederom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xiaoxiang781216 :-)

@cederom cederom mentioned this pull request Oct 13, 2024
Closed
@GUIDINGLI

GUIDINGLI commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

There are more than one places take CI error.
I think firstly resolve this obvious error.

And there are 3 PR fixes which are similar:
#2713
#2717
#2716

I prefer this current one.
And I will merge this PR, and close others.

@GUIDINGLI GUIDINGLI merged commit 2eeb750 into apache:master Oct 14, 2024
@lupyuen lupyuen mentioned this pull request Oct 14, 2024
Merged
@lupyuen

lupyuen commented Oct 14, 2024

Copy link
Copy Markdown
Member

I think it's still failing, due to the defconfig?

Configuration/Tool: qemu-armv8a/netnsh_smp
Normalize qemu-armv8a/netnsh_smp
102d101
< CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE=8192

https://github.com/apache/nuttx-apps/actions/runs/11320114328/job/31477189995

@lupyuen lupyuen mentioned this pull request Oct 14, 2024
Merged
@GUIDINGLI

GUIDINGLI commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Here is the fix:
apache/nuttx#14229

@lupyuen lupyuen mentioned this pull request Oct 14, 2024
Open
1 task
@xiaoxiang781216 xiaoxiang781216 deleted the telnetd branch October 14, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cederom cederom cederom approved these changes
@lupyuen lupyuen lupyuen approved these changes

Assignees

No one assigned

Labels

Size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiaoxiang781216 @GUIDINGLI @lupyuen @cederom