Skip to content

CI: Check out the correct branch of nuttx repo when compiling nuttx-apps#2780

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
lupyuen2:osref
Nov 4, 2024
Merged

CI: Check out the correct branch of nuttx repo when compiling nuttx-apps#2780
xiaoxiang781216 merged 1 commit into
apache:masterfrom
lupyuen2:osref

Conversation

@lupyuen

@lupyuen lupyuen commented Oct 27, 2024

Copy link
Copy Markdown
Member

Summary

When compiling the Release Branch of nuttx-apps, our CI Workflow build.yml checks out the Master Branch of nuttx repo, which is incorrect. This happens due to a typo in build.yml: apache/nuttx#14513

This PR fixes the typo in build.yml to checkout the correct branch of nuttx repo.

Impact

When compiling the Release Branch of nuttx-apps, our CI Workflow build.yml now checks out the Release Branch of nuttx repo.

No changes when compiling the Master Branch of nuttx and nuttx-apps repos.

Testing

Before the PR: Fetch-Source Log shows that CI is incorrectly checking out the Master Branch of nuttx repo (instead of releases/12.7): https://github.com/apache/nuttx-apps/actions/runs/11518661640/job/32069568370#step:3:66

/usr/bin/git checkout --progress --force -B master refs/remotes/origin/master

After the PR: When we change name to os_ref, CI correctly checks out the Release Branch of nuttx repo: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11528123257/job/32094821811#step:3:57

/usr/bin/git checkout --progress --force -B releases/12.7 refs/remotes/origin/releases/12.7

Regression Test:

@cederom cederom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen :-) Go ahead when ready :-)

@lupyuen

lupyuen commented Oct 27, 2024

Copy link
Copy Markdown
Member Author

Thanks @cederom! I'll wait till Oct 30, don't want to mess up our perfect GitHub Runners now :-)

@cederom

cederom commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

i have restarted the CI for verification :-)

@lupyuen

lupyuen commented Nov 2, 2024

Copy link
Copy Markdown
Member Author

@cederom Thanks! Let's wait for the broken builds to clear, so we won't pile on more problems :-)

When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` checks out the Master Branch of `nuttx` repo, which is incorrect. This happens due to a typo in `build.yml`: apache/nuttx#14513

This PR fixes the typo in `build.yml` to checkout the correct branch of `nuttx` repo.
@lupyuen lupyuen marked this pull request as ready for review November 4, 2024 02:35
@lupyuen lupyuen marked this pull request as draft November 4, 2024 02:36
@lupyuen lupyuen marked this pull request as ready for review November 4, 2024 04:14
@xiaoxiang781216 xiaoxiang781216 merged commit 594558e into apache:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] When building nuttx-apps, CI Workflow checks out the Incorrect Branch of nuttx repo

3 participants