fs cases: fix compile error#2905
Merged
Merged
Conversation
kernel/fs/cases/fs_stream_test.c:279:70: error: format ‘%zi’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=]
279 | syslog(LOG_ERR, "len = %zi != return value from fwrite = %zi",
| ~~^
| |
| long int
| %i
280 | len, ret);
| ~~~
| |
| int
kernel/fs/cases/fs_stream_test.c:311:69: error: format ‘%zi’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=]
311 | syslog(LOG_ERR, "len = %zi != return value from fread = %zi",
| ~~^
| |
| long int
| %i
312 | len, ret);
| ~~~
| |
| int
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
…long unsigned int', but argument 3 has type 'size_t' Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
|
[Experimental Bot, please feedback here] Yes, this PR likely meets the NuttX requirements, though it could be slightly improved. Strengths:
Weaknesses/Areas for Improvement:
Recommendation: Add the missing details mentioned above, especially the testing information. While the PR is likely acceptable as-is, providing more context will make it easier for reviewers to understand and approve the change. |
cederom
approved these changes
Dec 18, 2024
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @xiaoxiang781216 :-)
tmedicci
approved these changes
Dec 18, 2024
Contributor
|
Thanks, @xiaoxiang781216 ! |
Contributor
Author
|
@jerpelea please merge this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
fix compiler warning
Testing
ci