Skip to content

Update toywasm to v65.0.0 and fixes SPDX stuff#2920

Merged
xiaoxiang781216 merged 4 commits into
apache:masterfrom
yamt:toywasm-65
Dec 29, 2024
Merged

Update toywasm to v65.0.0 and fixes SPDX stuff#2920
xiaoxiang781216 merged 4 commits into
apache:masterfrom
yamt:toywasm-65

Conversation

@yamt

@yamt yamt commented Dec 29, 2024

Copy link
Copy Markdown
Contributor

Summary

Impact

Testing

yamt added 4 commits December 29, 2024 15:22
Note that these files are templates used by regen.sh script.
```
REF=e972e94fa427c3371fb21ad4bb9f238a1cca7795 ./regen.sh
```
@nuttxpr

nuttxpr commented Dec 29, 2024

Copy link
Copy Markdown

[Experimental Bot, please feedback here]

Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.

Summary

This PR lacks a summary. The author needs to describe the change's purpose, the affected code area, the mechanics of the change, and link any relevant NuttX or NuttX Apps issues/PRs. Without this information, it's impossible to assess the PR's value or correctness.

Impact

The impact assessment is entirely missing. The author must address each impact category (user, build, hardware, documentation, security, compatibility) with either "NO" or a "YES" followed by a clear description of the impact. This helps reviewers understand potential consequences and ensures thorough consideration of all aspects of the change.

Testing

The testing section is incomplete. While the template is present, the author hasn't provided any information about their testing environment (build host and target details) or included any testing logs. Reviewers need this information to verify the claimed functionality and assess the change's stability. The "I confirm..." statement is meaningless without concrete evidence. The author must provide specific build host and target details and include relevant "before" and "after" logs demonstrating the change's effect.

In short, this PR does not meet the NuttX requirements. It lacks critical information in all three sections (Summary, Impact, and Testing) making it impossible to review effectively.

@xiaoxiang781216 xiaoxiang781216 merged commit 7a36a70 into apache:master Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants