apps/nshlib: Remove the deprecated config NSH_LINELEN#2945
Merged
xiaoxiang781216 merged 1 commit intoJan 16, 2025
Merged
Conversation
cederom
approved these changes
Jan 15, 2025
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @JianyuWang0623 :-)
Contributor
|
Maybe a short mention in the git commit message would be helpful for anyone in the future to understand why it was removed? NSH_LINELEN is replaced by POSIX standard LINE_MAX. |
NSH_LINELEN is replaced by POSIX standard LINE_MAX. apache/nuttx#15541 apache#2943 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
JianyuWang0623
force-pushed
the
br_wjy_nshlib_rm_LINELEN_config_250115_apache
branch
from
ad1e04a to
838d3cf
Compare
Contributor
Author
OK |
xiaoxiang781216
approved these changes
Jan 15, 2025
jerpelea
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSH_LINELEN.LINE_MAXis used instead.CONFIG_NSH_LINELENwithCONFIG_LINE_MAXnuttx#15541 and apps/nshlib: Usinglib_get_tempbuffer()to save stack space #2943 please.Impact
apps/nshlib
Testing
CI