apps/testing:move arch_libc, fmemopen, scanftest folders to the new libc folder#2964
Merged
Merged
Conversation
…ib folder Signed-off-by: tengshuangshuang <tengshuangshuang@xiaomi.com>
|
[Experimental Bot, please feedback here] Yes, this PR appears to meet the basic NuttX requirements, though it could be more thorough. Here's a breakdown: Strengths:
Weaknesses:
Recommendation: While the PR seems to meet the letter of the requirements, adding the missing details, especially regarding testing and build environment, would significantly improve its quality and make review easier. Even a simple "Built and tested on Linux with GCC 12.x, CI passed on sim:nsh" would be a substantial improvement. Explaining the rationale behind the restructuring would also be beneficial. |
xiaoxiang781216
approved these changes
Jan 22, 2025
cederom
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is one step that merge test case as discussed in #2931.
Create libc folder and move arch_libc, fmemopen, scanftest folders to the new libc folder.
Impact
Only affect apps/testing folder
New folder :
libc
Move the following folder:
arch_libc, fmemopen, scanftest
Testing
CI test