system/cpuload: Fix application's Make.defs location#3002
Merged
Conversation
The PR apache#2974 first moved it to `testing/sched/cpuload` and the Make.defs was adjusted accordingly. However, during the review process, it was moved to `system/cpuload` folder, but its Make.defs wasn't updated. This commit fixes it. Signed-off-by: Tiago Medicci <tiago.medicci@espressif.com>
lupyuen
approved these changes
Feb 19, 2025
Donny9
approved these changes
Feb 20, 2025
raiden00pl
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR #2974 first moved it to
testing/sched/cpuloadand theMake.defswas adjusted accordingly. However, during the review process, it was moved tosystem/cpuloadfolder, but itsMake.defswasn't updated. This PR fixes it.Impact
Impact on user: YES. It enables users to build
cpuloadapp.Impact on build: YES. Now we can build it.
Impact on hardware: NO.
Impact on documentation: NO.
Impact on security: NO.
Impact on compatibility: NO.
Testing
Test it for ESP32-S3's
nshdefconfig, for instance:Building
Running
Run
cpuloadon NSH:Results
Before applying this patch, it fails to build with:
Now, it's been fixed ;)